linux-kernel - Re: [PATCH v2 2/2] of/irq: Use helper to define resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240910220034.GC12725@vamoiridPC>
Date: Wed, 11 Sep 2024 00:00:34 +0200
From: Vasileios Amoiridis <vassilisamir@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Vasileios Amoiridis <vassilisamir@...il.com>, robh@...nel.org,
	saravanak@...gle.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] of/irq: Use helper to define resources

On Sun, Sep 08, 2024 at 10:44:15AM +0200, Krzysztof Kozlowski wrote:
> On Thu, Sep 05, 2024 at 11:34:54AM +0300, Andy Shevchenko wrote:
> > On Wed, Sep 04, 2024 at 06:02:38PM +0200, Vasileios Amoiridis wrote:
> > > Resources definition can become simpler and more organised by using the
> > > dedicated helpers.
> > 
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > 
> > ...
> > 
> > > +		*r = DEFINE_RES_IRQ_NAMED(irq, name ? name : of_node_full_name(dev))
> > 
> > Just use Elvis to make this shorten.
> > Btw, have you ever compiled this?
> 
> It wasn't ever built... and if not built, probably not tested, either.
> 
> Best regards,
> Krzysztof
> 

Hi Andy, Krzysztof,

That is a stupid mistake. I was sending around quite some patches and
lost concentration a bit. Will fix that.

Cheers,
Vasilis