linux-kernel - Re: [PATCH 1/6] staging: rtl8723bs: fix use of tab wherever possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4176c4f5-7da4-4f0a-a632-d2a46b8d3035@gmail.com>
Date: Sun, 8 Sep 2024 22:23:26 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Sayyad Abid <sayyad.abid16@...il.com>, linux-staging@...ts.linux.dev
Cc: gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] staging: rtl8723bs: fix use of tab wherever possible

On 9/8/24 12:11, Sayyad Abid wrote:
> This patch fixes the coding style issue by fixing the use of space
> instead of tabs on line.
> 
> Signed-off-by: Sayyad Abid <sayyad.abid16@...il.com>

Hi Sayyad,

please make your "Subject" line more unique. Consider that we may end up 
with having dozen of commits like yours, all of them referring to 
different removals and all without the necessary information to tell 
what they differ in (except the driver/subsystem). So it would help if 
you add the changed file or function to make it more unique.

Please also improve the Subject Lines of the other patches.

If you send in a second version of this patch please use a change 
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Thanks for your support.

Bye Philipp

> 
> ---
>   drivers/staging/rtl8723bs/include/rtw_security.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtw_security.h b/drivers/staging/rtl8723bs/include/rtw_security.h
> index 98afbd3054a4..487d69460cec 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_security.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_security.h
> @@ -75,8 +75,8 @@ struct {
>   };
>   
>   union Keytype {
> -        u8   skey[16];
> -        u32    lkey[4];
> +	u8   skey[16];
> +	u32    lkey[4];
>   };
>   
>