linux-kernel - Re: [PATCH 4/6] staging: rtl8723bs: fix comment with a trailing */ on a separate line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4bc6cfea-ecf4-40ad-a3f6-c32bb411949a@gmail.com>
Date: Sun, 8 Sep 2024 22:26:10 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Sayyad Abid <sayyad.abid16@...il.com>, linux-staging@...ts.linux.dev
Cc: gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] staging: rtl8723bs: fix comment with a trailing */ on
 a separate line

On 9/8/24 12:11, Sayyad Abid wrote:
> This patch fixes the trailing "*/" on a comment block.

Hi Sayyad,

important is to describe why this patch makes the code better. You 
described in the description just what you did. But that can be seen in 
the changed lines blow.

Thanks

Bye Philipp

> 
> Signed-off-by: Sayyad Abid <sayyad.abid16@...il.com>
> 
> ---
>   drivers/staging/rtl8723bs/include/rtw_security.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtw_security.h b/drivers/staging/rtl8723bs/include/rtw_security.h
> index 4efa2d258ebf..1e5e7f52f8da 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_security.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_security.h
> @@ -240,7 +240,8 @@ struct mic_data {
>   /* ===== start - public domain SHA256 implementation ===== */
>   
>   /* This is based on SHA256 implementation in LibTomCrypt that was released into
> - * public domain by Tom St Denis. */
> + * public domain by Tom St Denis.
> + */
>   
>   int omac1_aes_128(u8 *key, u8 *data, size_t data_len, u8 *mac);
>   void rtw_secmicsetkey(struct mic_data *pmicdata, u8 *key);