linux-kernel - Re: [PATCH] locking/rwsem: Move is_rwsem_reader_owned() and rwsem_owner() under CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7efd55de-51a8-4ffa-88c2-d8c94b1fb2bd@redhat.com>
Date: Tue, 10 Sep 2024 14:04:35 -0400
From: Waiman Long <longman@...hat.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Will Deacon <will.deacon@....com>, Boqun Feng <boqun.feng@...il.com>,
 linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
 Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling
 <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH] locking/rwsem: Move is_rwsem_reader_owned() and
 rwsem_owner() under CONFIG_DEBUG_RWSEMS


On 9/10/24 12:01, Andy Shevchenko wrote:
> On Tue, Sep 10, 2024 at 11:47:17AM -0400, Waiman Long wrote:
>> On 9/10/24 04:16, Andy Shevchenko wrote:
>>> On Tue, Sep 10, 2024 at 11:15:54AM +0300, Andy Shevchenko wrote:
>>>> On Mon, Sep 09, 2024 at 02:29:05PM -0400, Waiman Long wrote:
>>>>> Both is_rwsem_reader_owned() and rwsem_owner() are currently only used when
>>>>> CONFIG_DEBUG_RWSEMS is defined. This causes a compilation error with clang
>>>>> when `make W=1` and CONFIG_WERROR=y:
>>>>>
>>>>> kernel/locking/rwsem.c:187:20: error: unused function 'is_rwsem_reader_owned' [-Werror,-Wunused-function]
>>>>>     187 | static inline bool is_rwsem_reader_owned(struct rw_semaphore *sem)
>>>>>         |                    ^~~~~~~~~~~~~~~~~~~~~
>>>>> kernel/locking/rwsem.c:271:35: error: unused function 'rwsem_owner' [-Werror,-Wunused-function]
>>>>>     271 | static inline struct task_struct *rwsem_owner(struct rw_semaphore *sem)
>>>>>         |                                   ^~~~~~~~~~~
>>>>>
>>>>> Fix this by moving these two functions under the CONFIG_DEBUG_RWSEMS define.
>>>> At least this solves my issue,
>>>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>> ...and
>>>
>>> Tested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> Thanks for the testing.
>>
>> No functional change is intended for this patch. Ingo & Peter, can this
>> patch lands in v6.12 or has to wait until v6.13?
> I see it already in PeterZ's tree.
>
Right. It is in PeterZ's tree. I didn't check his tree that often. 
Thanks for letting me know.

Cheers,
Longman