linux-kernel - Re: [PATCH v1] security/apparmor: remove duplicate unpacking in unpack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240910205744.GA314978@mail.hallyn.com>
Date: Tue, 10 Sep 2024 15:57:44 -0500
From: "Serge E. Hallyn" <serge@...lyn.com>
To: John Johansen <john.johansen@...onical.com>
Cc: Shen Lichuan <shenlichuan@...o.com>, Paul Moore <paul@...l-moore.com>,
	James Morris <jmorris@...ei.org>,
	"Serge E. Hallyn" <serge@...lyn.com>, apparmor@...ts.ubuntu.com,
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org,
	opensource.kernel@...o.com
Subject: Re: [PATCH v1] security/apparmor: remove duplicate unpacking in
 unpack_perm function

On Mon, Sep 09, 2024 at 11:57:05PM -0700, John Johansen wrote:
> On 8/21/24 00:22, Shen Lichuan wrote:
> > The code was unpacking the 'allow' parameter twice.
> > This change removes the duplicate part.
> > 
> > Signed-off-by: Shen Lichuan <shenlichuan@...o.com>
> 
> NAK, this would break the unpack. The first entry is actually a reserved
> value and is just being thrown away atm. Instead of double unpacking to
> perms->allow we could unpack it to a temp variable that just gets discarded

Heh, I recon this should probably be documented in a comment? :)
> 
> 
> > ---
> >   security/apparmor/policy_unpack.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/security/apparmor/policy_unpack.c b/security/apparmor/policy_unpack.c
> > index 5a570235427d..4ec1e1251012 100644
> > --- a/security/apparmor/policy_unpack.c
> > +++ b/security/apparmor/policy_unpack.c
> > @@ -649,7 +649,6 @@ static bool unpack_perm(struct aa_ext *e, u32 version, struct aa_perms *perm)
> >   		return false;
> >   	return	aa_unpack_u32(e, &perm->allow, NULL) &&
> > -		aa_unpack_u32(e, &perm->allow, NULL) &&
> >   		aa_unpack_u32(e, &perm->deny, NULL) &&
> >   		aa_unpack_u32(e, &perm->subtree, NULL) &&
> >   		aa_unpack_u32(e, &perm->cond, NULL) &&
>