linux-kernel - Re: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA running on different channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zt_h_mW4nFWKu2SI@pengutronix.de>
Date: Tue, 10 Sep 2024 08:06:54 +0200
From: Sascha Hauer <s.hauer@...gutronix.de>
To: David Lin <yu-hao.lin@....com>
Cc: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"briannorris@...omium.org" <briannorris@...omium.org>,
	"kvalo@...nel.org" <kvalo@...nel.org>,
	"francesco@...cini.it" <francesco@...cini.it>,
	Pete Hsieh <tsung-hsien.hsieh@....com>
Subject: Re: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA running on
 different channel

On Tue, Sep 10, 2024 at 05:56:58AM +0000, David Lin wrote:
> > From: Sascha Hauer <s.hauer@...gutronix.de>
> > Sent: Tuesday, September 10, 2024 1:56 PM
> > To: David Lin <yu-hao.lin@....com>
> > Cc: linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org;
> > briannorris@...omium.org; kvalo@...nel.org; francesco@...cini.it; Pete
> > Hsieh <tsung-hsien.hsieh@....com>
> > Subject: Re: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA running on
> > different channel
> > 
> > Caution: This is an external email. Please take care when clicking links or
> > opening attachments. When in doubt, report the message using the 'Report
> > this email' button
> > 
> > 
> > On Tue, Sep 10, 2024 at 01:55:14AM +0000, David Lin wrote:
> > > > From: Sascha Hauer <s.hauer@...gutronix.de>
> > > > Sent: Tuesday, September 10, 2024 4:33 AM
> > > > To: David Lin <yu-hao.lin@....com>
> > > > Cc: linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org;
> > > > briannorris@...omium.org; kvalo@...nel.org; francesco@...cini.it;
> > > > Pete Hsieh <tsung-hsien.hsieh@....com>
> > > > Subject: Re: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA
> > > > running on different channel
> > > >
> > > > Caution: This is an external email. Please take care when clicking
> > > > links or opening attachments. When in doubt, report the message
> > > > using the 'Report this email' button
> > > >
> > > >
> > > > On Mon, Sep 02, 2024 at 10:35:01AM +0000, David Lin wrote:
> > > > > > From: Sascha Hauer <s.hauer@...gutronix.de>
> > > > > > Sent: Monday, September 2, 2024 5:38 PM
> > > > > > To: David Lin <yu-hao.lin@....com>
> > > > > > Cc: linux-wireless@...r.kernel.org;
> > > > > > linux-kernel@...r.kernel.org; briannorris@...omium.org;
> > > > > > kvalo@...nel.org; francesco@...cini.it; Pete Hsieh
> > > > > > <tsung-hsien.hsieh@....com>
> > > > > > Subject: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA
> > > > > > running on different channel
> > > > > >
> > > > > > On Mon, Sep 02, 2024 at 04:43:11PM +0800, David Lin wrote:
> > > > > > > Current firmware doesn't support AP and STA running on
> > > > > > > different channels simultaneously.
> > > > > >
> > > > > > As mentioned here:
> > > > > >
> > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%
> > > > > >
> > 2Flo%2F&data=05%7C02%7Cyu-hao.lin%40nxp.com%7Cd0a1e3797a0d4acd7a
> > > > > >
> > 9c08dcd15d3ddb%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638
> > 6
> > > > > >
> > 15445620612026%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ
> > QI
> > > > > >
> > joiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=5yC
> > > > > > jjIqxpV%2BJxlPdrCH0gRTQ%2FCQZKr%2FDc0S1cjkaIA8%3D&reserved=0
> > > > > >
> > > >
> > re.kern%2F&data=05%7C02%7Cyu-hao.lin%40nxp.com%7C7712df39ac37414fd
> > > > a7
> > > > > >
> > > >
> > e08dcd10eac35%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6386
> > > > 15108
> > > > > >
> > > >
> > 157502805%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV
> > > > 2luMz
> > > > > >
> > > >
> > IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=URNJPJE17iRY
> > > > Tu4i
> > > > > > rx7eQAC97tE5OE6a4kUfjUwuaVU%3D&reserved=0
> > > > > >
> > > >
> > el.org%2Fall%2FZtGnWC7SPHt7Vbbp%40pengutronix.de%2F&data=05%7C02%
> > > > > >
> > > >
> > 7Cyu-hao.lin%40nxp.com%7Cce9b7d4e417c41113c7d08dccb32fc49%7C686ea
> > > > > >
> > > >
> > 1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638608667089710854%7CUnkn
> > > > > >
> > > >
> > own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h
> > > > > >
> > > >
> > aWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=nMZO565xCUO%2BwxD4tIfi
> > > > > > w6cGyYrinaEsi7XLfqyxgXg%3D&reserved=0
> > > > > >
> > > > > > AP and STA can indeed have different channels when DRCS is
> > > > > > enabled, so I think you have to check this in your patch.
> > > > > >
> > > > > > Maybe the same question here again: Wouldn't it make sense to
> > > > > > enable DRCS by default?
> > > > > >
> > > > > > Sascha
> > > > > >
> > > > >
> > > > > I will look into DRCS support later after current tasks on hand.
> > > > > This patch is a quick fix to avoid firmware crash in the specific scenario.
> > > >
> > > > With DRCS support enabled AP and STA actually can run on different
> > > > channels with the current code. You are breaking this scenario with this
> > patch.
> > > >
> > > > Sascha
> > > >
> > >
> > > DRCS will be checked in the future.
> > 
> > By future you mean v3 of this patch?
> > 
> > Sascha
> > 
> 
> No schedule now.

I am getting confused now. You want us to abandon my patch in favour of
yours, but you have no plans to update your patch to avoid a regression
that you introduce with your patch?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |