linux-kernel - Re: [PATCH] riscv: remove useless pc check in stacktrace handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f6915c21-1dbd-44f6-a118-7e3a5c442e64@ghiti.fr>
Date: Tue, 10 Sep 2024 09:09:39 +0200
From: Alexandre Ghiti <alex@...ti.fr>
To: Clément Léger <cleger@...osinc.com>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>
Cc: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: remove useless pc check in stacktrace handling

Hi Clément,

On 30/08/2024 10:49, Clément Léger wrote:
> Checking for pc to be a kernel text address at this location is useless
> since pc == handle_exception. Remove this check.
>
> Signed-off-by: Clément Léger <cleger@...osinc.com>
>
> ---
>   arch/riscv/kernel/stacktrace.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/stacktrace.c b/arch/riscv/kernel/stacktrace.c
> index c6d5de22463f..f934c573c087 100644
> --- a/arch/riscv/kernel/stacktrace.c
> +++ b/arch/riscv/kernel/stacktrace.c
> @@ -72,7 +72,7 @@ void notrace walk_stackframe(struct task_struct *task, struct pt_regs *regs,
>   			pc = ftrace_graph_ret_addr(current, &graph_idx, frame->ra,
>   						   &frame->ra);
>   			if (pc == (unsigned long)handle_exception) {
> -				if (unlikely(!__kernel_text_address(pc) || !fn(arg, pc)))
> +				if (unlikely(!fn(arg, pc)))
>   					break;
>   
>   				pc = ((struct pt_regs *)sp)->epc;


Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>

Thanks,

Alex