linux-kernel - Re: [PATCH -next] printk: Export match_devname_and_update_preferred

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zt_w5x4Z-jSillvr@tlindgre-MOBL1>
Date: Tue, 10 Sep 2024 10:10:31 +0300
From: Tony Lindgren <tony.lindgren@...ux.intel.com>
To: Petr Mladek <pmladek@...e.com>
Cc: Yu Liao <liaoyu15@...wei.com>, liwei391@...wei.com, rostedt@...dmis.org,
	john.ogness@...utronix.de, senozhatsky@...omium.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] printk: Export
 match_devname_and_update_preferred_console()

On Tue, Sep 10, 2024 at 08:41:38AM +0200, Petr Mladek wrote:
> On Mon 2024-09-09 13:56:28, Tony Lindgren wrote:
> > On Mon, Sep 09, 2024 at 11:25:58AM +0300, Tony Lindgren wrote:
> > > On Mon, Sep 09, 2024 at 03:56:52PM +0800, Yu Liao wrote:
> > > > When building serial_base as a module, modpost fails with the following
> > > > error message:
> > > > 
> > > >   ERROR: modpost: "match_devname_and_update_preferred_console"
> > > >   [drivers/tty/serial/serial_base.ko] undefined!
> > > > 
> > > > Export the symbol to allow using it from modules.
> > > 
> > > I think the issue is with CONFIG_PRINTK is no set, and serial drivers
> > > select SERIAL_CORE_CONSOLE? And when serial_base is a module, there is
> > > no kernel console.
> > > 
> > > I replied earlier today to the lkp error report along those lines, but
> > > please let me know if there is more to the issue than that.
> > 
> > Sorry I gave wrong information above. The issue can be hit also with
> > CONFIG_PRINTK=y and serial_base as a loadable module.
> 
> Yes, this is my understanding. The problem has happened when serial_base
> was built as a module. So exporting the symbol looks like the right fix.

Yes agreed.

And, Yu, thanks for fixing the issue!

Regards,

Tony