linux-kernel - RE: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA running on different channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PA4PR04MB9638E715A4B73787E8EC28D7D19A2@PA4PR04MB9638.eurprd04.prod.outlook.com>
Date: Tue, 10 Sep 2024 08:21:12 +0000
From: David Lin <yu-hao.lin@....com>
To: Sascha Hauer <s.hauer@...gutronix.de>
CC: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"briannorris@...omium.org" <briannorris@...omium.org>, "kvalo@...nel.org"
	<kvalo@...nel.org>, "francesco@...cini.it" <francesco@...cini.it>, Pete Hsieh
	<tsung-hsien.hsieh@....com>
Subject: RE: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA running on
 different channel

> From: Sascha Hauer <s.hauer@...gutronix.de>
> Sent: Tuesday, September 10, 2024 4:08 PM
> To: David Lin <yu-hao.lin@....com>
> Cc: linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org;
> briannorris@...omium.org; kvalo@...nel.org; francesco@...cini.it; Pete
> Hsieh <tsung-hsien.hsieh@....com>
> Subject: Re: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA running on
> different channel
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Tue, Sep 10, 2024 at 07:28:29AM +0000, David Lin wrote:
> > > From: Sascha Hauer <s.hauer@...gutronix.de>
> > > Sent: Tuesday, September 10, 2024 3:22 PM
> > > To: David Lin <yu-hao.lin@....com>
> > > Cc: linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org;
> > > briannorris@...omium.org; kvalo@...nel.org; francesco@...cini.it;
> > > Pete Hsieh <tsung-hsien.hsieh@....com>
> > > Subject: Re: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA
> > > running on different channel
> > >
> > > Caution: This is an external email. Please take care when clicking
> > > links or opening attachments. When in doubt, report the message
> > > using the 'Report this email' button
> > >
> > >
> > > On Tue, Sep 10, 2024 at 06:18:57AM +0000, David Lin wrote:
> > > > > > > > > With DRCS support enabled AP and STA actually can run on
> > > > > > > > > different channels with the current code. You are
> > > > > > > > > breaking this scenario with this
> > > > > > > patch.
> > > > > > > > >
> > > > > > > > > Sascha
> > > > > > > > >
> > > > > > > >
> > > > > > > > DRCS will be checked in the future.
> > > > > > >
> > > > > > > By future you mean v3 of this patch?
> > > > > > >
> > > > > > > Sascha
> > > > > > >
> > > > > >
> > > > > > No schedule now.
> > > > >
> > > > > I am getting confused now. You want us to abandon my patch in
> > > > > favour of yours, but you have no plans to update your patch to
> > > > > avoid a regression that you introduce with your patch?
> > > > >
> > > > > Sascha
> > > > >
> > > >
> > > > My patch resolves the same issue as your patch. But your patch
> > > > can't let AP and STA run on the same channel if some wiphy
> > > > parameters are set.
> > > >
> > > > I wonder did you test your patch?
> > >
> > > I finally see what you mean with "some wiphy parameters are set".
> > > I did test my patch and I didn't run into this issue, because I
> > > haven't set anything like rts_threshold in my config.
> > >
> > > Nevertheless what I am trying to tell you in this thread is: Your
> > > patch introduces a regression and needs an update.
> > >
> > > It's not about my patch or your patch, both are currently not
> > > suitable for inclusion and the question is: will you update your patch?
> > >
> > > Sascha
> > >
> >
> > Without DRCS, this patch can avoid firmware crash and this is the
> > current plan for Mwifiex.  It won't affect any existing features.
> 
> What I am trying to tell you: Your patch fixes one thing and breaks another.
> 
> The current mwifiex driver *does* support DRCS when enabled with the
> drcs=1 module parameter. With DRCS enabled the current driver *can*
> successfully run an Accesspoint on one channel and a station on another
> channel. You are breaking this with your patch.
> 
> Your mwifiex_is_channel_setting_allowable() needs this:
> 
>         if (adapter->drcs_enabled)
>                 return true;
> 
> Sascha
> 

Thanks. Because the code is ported from nxpwifi which removes DRCS. I will add this check in patch v3.

David