[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1778254.M3retTD8dW@diego>
Date: Tue, 10 Sep 2024 10:24:25 +0200
From: Heiko Stübner <heiko@...ech.de>
To: Damon Ding <damon.ding@...k-chips.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
macromorgan@...mail.com, jonas@...boo.se, tim@...thertop.org,
knaerzche@...il.com, efectn@...tonmail.com, andyshrk@....com,
jagan@...eble.ai, dsimic@...jaro.org, megi@....cz,
sebastian.reichel@...labora.com, alchark@...il.com,
boris.brezillon@...labora.com, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
linux-kernel@...r.kernel.org, Damon Ding <damon.ding@...k-chips.com>
Subject:
Re: [PATCH v1 2/2] arm64: dts: rockchip: Add support for rk3588s evb1 board
Am Dienstag, 10. September 2024, 05:09:51 CEST schrieb Damon Ding:
> Specification:
> - Rockchip RK3588S
> - RK806-2x2pcs + DiscretePower
> - eMMC5.1 + SPI Flash
> - Micro SD Card3.0
> - 1 x Typec3.0 + 2 x USB2 HOST
> - 1 x 1Lane PCIE2.0 Connector(RC Mode)
> - Headphone output
> - Array Key(MENU/VOL+/VOP-/ESC), Reset, Power on/off Key
> - 6 x SARADC
>
> Signed-off-by: Damon Ding <damon.ding@...k-chips.com>
> ---
[...]
> + analog-sound {
> + compatible = "simple-audio-card";
> + pinctrl-names = "default";
> + pinctrl-0 = <&hp_detect>;
> + simple-audio-card,name = "RK3588 EVB1 Audio";
> + simple-audio-card,aux-devs = <&_headphone>, <&_speaker>;
> + simple-audio-card,bitclock-master = <&masterdai>;
> + simple-audio-card,format = "i2s";
> + simple-audio-card,frame-master = <&masterdai>;
> + simple-audio-card,hp-det-gpio = <&gpio1 RK_PD5 GPIO_ACTIVE_LOW>;
> + simple-audio-card,mclk-fs = <256>;
> + simple-audio-card,pin-switches = "Headphones", "Speaker";
> + simple-audio-card,routing =
> + "Speaker Amplifier INL", "LOUT2",
> + "Speaker Amplifier INR", "ROUT2",
> + "Speaker", "Speaker Amplifier OUTL",
> + "Speaker", "Speaker Amplifier OUTR",
> + "Headphones Amplifier INL", "LOUT1",
> + "Headphones Amplifier INR", "ROUT1",
> + "Headphones", "Headphones Amplifier OUTL",
> + "Headphones", "Headphones Amplifier OUTR",
> + "LINPUT1", "Onboard Microphone",
> + "RINPUT1", "Onboard Microphone",
> + "LINPUT2", "Microphone Jack",
> + "RINPUT2", "Microphone Jack";
> + simple-audio-card,widgets =
> + "Microphone", "Microphone Jack",
> + "Microphone", "Onboard Microphone",
> + "Headphone", "Headphones",
> + "Speaker", "Speaker";
> +
> + simple-audio-card,cpu {
> + sound-dai = <&i2s0_8ch>;
> + };
> +
> + masterdai: simple-audio-card,codec {
> + sound-dai = <&es8388>;
> + system-clock-frequency = <12288000>;
> + };
> + };
> +
> + amp_headphone: headphone-amplifier {
> + compatible = "simple-audio-amplifier";
> + enable-gpios = <&gpio4 RK_PA4 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&headphone_amplifier_en>;
> + sound-name-prefix = "Headphones Amplifier";
> + };
> +
> + amp_speaker: speaker-amplifier {
> + compatible = "simple-audio-amplifier";
> + enable-gpios = <&gpio4 RK_PA5 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&speaker_amplifier_en>;
> + sound-name-prefix = "Speaker Amplifier";
> + };
> +
> + backlight: backlight {
please sort nodes by node name ... so "backlight" after "analog-sound"
> + compatible = "pwm-backlight";
> + power-supply = <&vcc3v3_lcd_edp>;
> + pwms = <&pwm12 0 25000 0>;
> + };
> +
> + combophy_avdd0v85: combophy-avdd0v85-regulator {
generally the naming convention for regulator nodes now is
regulator-* ... so regulator-combophy-avdd0v85 here
and similar for others below.
Heiko
Powered by blists - more mailing lists