linux-kernel - Re: [PATCH v2 8/9] dt-bindings: phy: sparx5: document lan969x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240910085952.azwmrvuntyvuc3nb@DEN-DL-M70577>
Date: Tue, 10 Sep 2024 08:59:52 +0000
From: Daniel Machon <daniel.machon@...rochip.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>,
	Lars Povlsen <lars.povlsen@...rochip.com>, Steen Hegelund
	<Steen.Hegelund@...rochip.com>, <UNGLinuxDriver@...rochip.com>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, <linux-phy@...ts.infradead.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 8/9] dt-bindings: phy: sparx5: document lan969x

> >  maintainers:
> >    - Steen Hegelund <steen.hegelund@...rochip.com>
> > +  - Daniel Machon <daniel.machon@...rochip.com>
> >
> >  description: |
> >    The Sparx5 SERDES interfaces share the same basic functionality, but
> > @@ -62,12 +63,26 @@ description: |
> >    * 10.3125 Gbps (10GBASE-R/10GBASE-KR/USXGMII)
> >    * 25.78125 Gbps (25GBASE-KR/25GBASE-CR/25GBASE-SR/25GBASE-LR/25GBASE-ER)
> >
> > +  lan969x has ten SERDES10G interfaces that share the same features, operating
> > +  modes and data rates as the equivalent Sparx5 SERDES10G interfaces.
> > +
> >  properties:
> >    $nodename:
> >      pattern: "^serdes@[0-9a-f]+$"
> >
> >    compatible:
> > -    const: microchip,sparx5-serdes
> > +    oneOf:
> > +      - enum:
> > +          - microchip,sparx5-serdes
> > +          - microchip,lan9691-serdes
> > +      - items:
> > +          - enum:
> > +              - microchip,lan9698-serdes
> > +              - microchip,lan9696-serdes
> > +              - microchip,lan9694-serdes
> > +              - microchip,lan9693-serdes
> > +              - microchip,lan9692-serdes
> 
> If there is going to be a new version, keep rather increasing/growing
> alphanumerical order, but no need to resend just for this.

Ack.

> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Best regards,
> Krzysztof
>

Thanks for reviewing!

/Daniel