[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <wd3gzn3lpmw64qor3xslif6rnp7htycfhu33pa2xpxvv6mrwqe@nv6pcwkstywe>
Date: Tue, 10 Sep 2024 09:40:12 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Daniel Machon <daniel.machon@...rochip.com>
Cc: Vinod Koul <vkoul@...nel.org>,
Kishon Vijay Abraham I <kishon@...nel.org>, Lars Povlsen <lars.povlsen@...rochip.com>,
Steen Hegelund <Steen.Hegelund@...rochip.com>, UNGLinuxDriver@...rochip.com, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
linux-phy@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 8/9] dt-bindings: phy: sparx5: document lan969x
On Mon, Sep 09, 2024 at 05:14:48PM +0200, Daniel Machon wrote:
> Lan969x is going to reuse the existing Sparx5 SERDES driver - document
> that by adding compatible strings for the different SKU's that we
> support, and a short description of the SERDES types and data rates
> supported.
>
> Signed-off-by: Daniel Machon <daniel.machon@...rochip.com>
> Reviewed-by: Steen Hegelund <Steen.Hegelund@...rochip.com>
> ---
> .../bindings/phy/microchip,sparx5-serdes.yaml | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/microchip,sparx5-serdes.yaml b/Documentation/devicetree/bindings/phy/microchip,sparx5-serdes.yaml
> index bdbdb3bbddbe..fa0b02916dac 100644
> --- a/Documentation/devicetree/bindings/phy/microchip,sparx5-serdes.yaml
> +++ b/Documentation/devicetree/bindings/phy/microchip,sparx5-serdes.yaml
> @@ -8,6 +8,7 @@ title: Microchip Sparx5 Serdes controller
>
> maintainers:
> - Steen Hegelund <steen.hegelund@...rochip.com>
> + - Daniel Machon <daniel.machon@...rochip.com>
>
> description: |
> The Sparx5 SERDES interfaces share the same basic functionality, but
> @@ -62,12 +63,26 @@ description: |
> * 10.3125 Gbps (10GBASE-R/10GBASE-KR/USXGMII)
> * 25.78125 Gbps (25GBASE-KR/25GBASE-CR/25GBASE-SR/25GBASE-LR/25GBASE-ER)
>
> + lan969x has ten SERDES10G interfaces that share the same features, operating
> + modes and data rates as the equivalent Sparx5 SERDES10G interfaces.
> +
> properties:
> $nodename:
> pattern: "^serdes@[0-9a-f]+$"
>
> compatible:
> - const: microchip,sparx5-serdes
> + oneOf:
> + - enum:
> + - microchip,sparx5-serdes
> + - microchip,lan9691-serdes
> + - items:
> + - enum:
> + - microchip,lan9698-serdes
> + - microchip,lan9696-serdes
> + - microchip,lan9694-serdes
> + - microchip,lan9693-serdes
> + - microchip,lan9692-serdes
If there is going to be a new version, keep rather increasing/growing
alphanumerical order, but no need to resend just for this.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Best regards,
Krzysztof
Powered by blists - more mailing lists