linux-kernel - Re: [PATCH V9 net-next 03/11] net: hibmcge: Add mdio and hardware configuration supported in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c876485-3094-41d7-a6cf-d4c9aaaf0b3d@huawei.com>
Date: Tue, 10 Sep 2024 21:54:04 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <shenjian15@...wei.com>,
	<wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>, <chenhao418@...wei.com>,
	<sudongming1@...wei.com>, <xujunsheng@...wei.com>, <shiyongbang@...wei.com>,
	<libaihan@...wei.com>, <jdamato@...tly.com>, <horms@...nel.org>,
	<kalesh-anakkur.purayil@...adcom.com>, <jonathan.cameron@...wei.com>,
	<shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V9 net-next 03/11] net: hibmcge: Add mdio and hardware
 configuration supported in this module


on 2024/9/10 20:21, Andrew Lunn wrote:
> On Tue, Sep 10, 2024 at 03:59:34PM +0800, Jijie Shao wrote:
>> this driver using phy through genphy device.
> As far as i can see, there is nothing here which limits you to
> genphy. The hardware could use any PHY driver which phylib has. In
> general, we don't recommend genphy, it is just a fallback driver which
> might work, but given the complexity of modern PHYs, also might not.
>
> What PHY do you actually have on the board?
>
> 	Andrew

We use YT8521，phylib already has this driver.
Therefore, when CONFIG_MOTORCOMM_PHY is enabled, the PHY driver is automatically used.

Thuis description is a bit misleading and I'll fix it in the next version.
I think I might need to add a dependency on CONFIG_MOTORCOMM_PHY in Kconfig

Thanks
	Jijie Shao