linux-kernel - Re: [PATCH V9 net-next 05/11] net: hibmcge: Implement some .ndo functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <817b7a3e-5e77-46bc-9918-e4eb1d322d31@huawei.com>
Date: Tue, 10 Sep 2024 21:58:53 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <shenjian15@...wei.com>,
	<wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>, <chenhao418@...wei.com>,
	<sudongming1@...wei.com>, <xujunsheng@...wei.com>, <shiyongbang@...wei.com>,
	<libaihan@...wei.com>, <jdamato@...tly.com>, <horms@...nel.org>,
	<kalesh-anakkur.purayil@...adcom.com>, <jonathan.cameron@...wei.com>,
	<shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V9 net-next 05/11] net: hibmcge: Implement some .ndo
 functions


on 2024/9/10 20:34, Andrew Lunn wrote:
> On Tue, Sep 10, 2024 at 03:59:36PM +0800, Jijie Shao wrote:
>> +
>> @@ -88,6 +181,10 @@ static int hbg_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>>   	if (ret)
>>   		return ret;
>>   
>> +	netdev->max_mtu = priv->dev_specs.max_mtu;
>> +	netdev->min_mtu = priv->dev_specs.min_mtu;
>> +	hbg_change_mtu(priv, HBG_DEFAULT_MTU_SIZE);
> It does not help that you added added HBG_DEFAULT_MTU_SIZE in a
> previous patch, but as far as i see, it is just ETH_DATA_LEN.
>
> Please use the standard defines, rather than adding your own. It makes
> the code a lot easier to understand, it is not using some special
> jumbo size by default, it is just the plain, boring, normal 1500
> bytes.
>
>      Andrew
>
The value of HBG_DEFAULT_MTU_SIZE is also 1500.
So，ETH_DATA_LEN can also be used.

Sorry I didn't notice ETH_DATA_LEN  before, I'll use it in V10.

Thanks,
	Jijie Shao