[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bbe81cd4-fee2-49fb-bb7d-66b1fc02a02d@huawei.com>
Date: Tue, 10 Sep 2024 22:01:44 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
<kuba@...nel.org>, <pabeni@...hat.com>, <shenjian15@...wei.com>,
<wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>, <chenhao418@...wei.com>,
<sudongming1@...wei.com>, <xujunsheng@...wei.com>, <shiyongbang@...wei.com>,
<libaihan@...wei.com>, <andrew@...n.ch>, <jdamato@...tly.com>,
<horms@...nel.org>, <jonathan.cameron@...wei.com>,
<shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V9 net-next 11/11] net: add ndo_validate_addr check in
dev_set_mac_address
on 2024/9/10 16:39, Kalesh Anakkur Purayil wrote:
> On Tue, Sep 10, 2024 at 1:36 PM Jijie Shao <shaojijie@...wei.com> wrote:
>> +++ b/net/core/dev.c
>> @@ -9087,6 +9087,11 @@ int dev_set_mac_address(struct net_device *dev, struct sockaddr *sa,
>> return -EOPNOTSUPP;
>> if (sa->sa_family != dev->type)
>> return -EINVAL;
>> + if (ops->ndo_validate_addr) {
>> + err = ops->ndo_validate_addr(dev);
>> + if (err)
>> + return err;
>> + }
> [Kalesh] It would be better to move this code after
> netif_device_present() check. Minor nit and there will not be any
> functional impact.
Yes, You are right,
For other reasons I need to send v10, I will move it.
Thanks,
Jijie Shao
Powered by blists - more mailing lists