linux-kernel - Re: [PATCH V2] Documentation: Improve crash_kexec_post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <121b62a7-bd2d-0ded-97a7-ac890831ca63@igalia.com>
Date: Wed, 11 Sep 2024 17:10:25 +0200
From: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To: Simon Horman <horms@...nel.org>
Cc: kexec@...ts.infradead.org, linux-doc@...r.kernel.org, bhe@...hat.com,
 corbet@....net, kernel@...ccoli.net, linux-kernel@...r.kernel.org,
 stephen.s.brennan@...cle.com, kernel-dev@...lia.com, dyoung@...hat.com,
 vgoyal@...hat.com, linux-debuggers@...r.kernel.org
Subject: Re: [PATCH V2] Documentation: Improve crash_kexec_post_notifiers
 description

On 02/09/2024 10:23, Simon Horman wrote:
> 
> Hi Guilherme,
> 
> Some subjective grammar nits.
> 
>> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
>> index efc52ddc6864..351730108c58 100644
>> --- a/Documentation/admin-guide/kernel-parameters.txt
>> +++ b/Documentation/admin-guide/kernel-parameters.txt
>> @@ -913,12 +913,16 @@
>>  			the parameter has no effect.
>>  
>>  	crash_kexec_post_notifiers
>> -			Run kdump after running panic-notifiers and dumping
>> -			kmsg. This only for the users who doubt kdump always
>> -			succeeds in any situation.
>> -			Note that this also increases risks of kdump failure,
>> -			because some panic notifiers can make the crashed
>> -			kernel more unstable.
>> +			Only jump to kdump kernel after running the panic
>> +			notifiers and dumping kmsg. This option increases the
>> +			risks of a kdump failure, since some panic notifiers
>> +			can make the crashed kernel more unstable. In the
> 
> nit: In the configurations -> In configurations
> 
>> +			configurations where kdump may not be reliable,
>> +			running the panic notifiers can allow collecting more
>> +			data on dmesg, like stack traces from other CPUS or
>> +			extra data dumped by panic_print. Notice that some
> 
> nit: Notice that -> Note that
> 
>> +			code enables this option unconditionally, like
> 
> Maybe: some code enables -> some configurations enable
> 

Hey Simon, tnx for the suggestions, will change in the next version.
Cheers,


Guilherme