linux-kernel - Re: [PATCH 2/8] dt-bindings: connector: Add MikorBUS connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172606837860.404675.7012990684888155394.robh@kernel.org>
Date: Wed, 11 Sep 2024 10:26:18 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Ayush Singh <ayush@...gleboard.org>
Cc: Alex Gaynor <alex.gaynor@...il.com>, 
 Derek Kiernan <derek.kiernan@....com>, Arnd Bergmann <arnd@...db.de>, 
 Alice Ryhl <aliceryhl@...gle.com>, Benno Lossin <benno.lossin@...ton.me>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 robertcnelson@...gleboard.org, d-gole@...com, linux-kernel@...r.kernel.org, 
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
 jkridner@...gleboard.org, Tero Kristo <kristo@...nel.org>, 
 Vignesh Raghavendra <vigneshr@...com>, Miguel Ojeda <ojeda@...nel.org>, 
 rust-for-linux@...r.kernel.org, Gary Guo <gary@...yguo.net>, 
 fabien.parent@...aro.org, Dragan Cvetic <dragan.cvetic@....com>, 
 Andrew Davis <afd@...com>, Conor Dooley <conor+dt@...nel.org>, 
 Nishanth Menon <nm@...com>, Andreas Hindborg <a.hindborg@...nel.org>, 
 lorforlinux@...gleboard.org, Boqun Feng <boqun.feng@...il.com>, 
 Trevor Gross <tmgross@...ch.edu>, linux-arm-kernel@...ts.infradead.org, 
 devicetree@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH 2/8] dt-bindings: connector: Add MikorBUS connector


On Wed, 11 Sep 2024 19:57:19 +0530, Ayush Singh wrote:
> Add DT bindings for mikroBUS interface. MikroBUS [0] is an open standard
> developed by MikroElektronika for connecting add-on boards to
> microcontrollers or microprocessors.
> 
> MikroBUS connector node will optionally act as nexus nodes for routing
> GPIOs and PWM.
> 
> For GPIOs, the following pin numbering should be followed:
> 
>   0: PWM
>   1: INT
>   2: RX
>   3: TX
>   4: SCL
>   5: SDA
>   6: MOSI
>   7: MISO
>   8: SCK
>   9: CS
>   10: RST
>   11: AN
> 
> For PWM, the PWM pin should be on channel 0.
> 
> I am not quite sure how to deal with the nexus node properties
> (#gpio-cells, gpio-map, gpio-map-mask, gpio-map-pass-thru) since they
> seem to conflict with upstream gpio schema (gpio-controller is a
> dependency of #gpio-cells).
> 
> [0]: https://www.mikroe.com/
> 
> Signed-off-by: Ayush Singh <ayush@...gleboard.org>
> ---
>  .../bindings/connector/mikrobus-connector.yaml     | 40 ++++++++++++++++++++++
>  MAINTAINERS                                        |  5 +++
>  2 files changed, 45 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/connector/mikrobus-connector.example.dtb: mikrobus-connector0: 'gpio-controller' is a dependency of '#gpio-cells'
	from schema $id: http://devicetree.org/schemas/gpio/gpio.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240911-mikrobus-dt-v1-2-3ded4dc879e7@beagleboard.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.