linux-kernel - Re: [PATCH] usb: dwc3: Runtime get and put usb power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240911221935.ghyfhwuzmezai6bv@synopsys.com>
Date: Wed, 11 Sep 2024 22:19:40 +0000
From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To: Greg KH <gregkh@...uxfoundation.org>
CC: Kyle Tso <kyletso@...gle.com>, Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        "raychi@...gle.com" <raychi@...gle.com>,
        "badhri@...gle.com" <badhri@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "royluo@...gle.com" <royluo@...gle.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc3: Runtime get and put usb power_supply handle

Hi Greg,

On Wed, Sep 11, 2024, Greg KH wrote:
> On Mon, Jul 15, 2024 at 10:58:27AM +0800, Kyle Tso wrote:
> > It is possible that the usb power_supply is registered after the probe
> > of dwc3. In this case, trying to get the usb power_supply during the
> > probe will fail and there is no chance to try again. Also the usb
> > power_supply might be unregistered at anytime so that the handle of it
> > in dwc3 would become invalid. To fix this, get the handle right before
> > calling to power_supply functions and put it afterward.
> > 
> > Fixes: 6f0764b5adea ("usb: dwc3: add a power supply for current control")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Kyle Tso <kyletso@...gle.com>
> > ---
> >  drivers/usb/dwc3/core.c   | 25 +++++--------------------
> >  drivers/usb/dwc3/core.h   |  4 ++--
> >  drivers/usb/dwc3/gadget.c | 19 ++++++++++++++-----
> >  3 files changed, 21 insertions(+), 27 deletions(-)
> 
> Did this get lost somewhere?  You might need to resend it now that Thinh
> is back from vacation.
> 

You're looking at the outdated patch. Here's where we left off from the
last discussion on v3 of this:

https://lore.kernel.org/linux-usb/20240810005634.6ig2e3hdsgx3wkan@synopsys.com/#t

BR,
Thinh