linux-kernel - Re: [PATCH] usb: dwc3: Runtime get and put usb power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024091114-armful-lure-1725@gregkh>
Date: Wed, 11 Sep 2024 15:29:33 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Kyle Tso <kyletso@...gle.com>
Cc: Thinh.Nguyen@...opsys.com, raychi@...gle.com, badhri@...gle.com,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	royluo@...gle.com, stable@...r.kernel.org
Subject: Re: [PATCH] usb: dwc3: Runtime get and put usb power_supply handle

On Mon, Jul 15, 2024 at 10:58:27AM +0800, Kyle Tso wrote:
> It is possible that the usb power_supply is registered after the probe
> of dwc3. In this case, trying to get the usb power_supply during the
> probe will fail and there is no chance to try again. Also the usb
> power_supply might be unregistered at anytime so that the handle of it
> in dwc3 would become invalid. To fix this, get the handle right before
> calling to power_supply functions and put it afterward.
> 
> Fixes: 6f0764b5adea ("usb: dwc3: add a power supply for current control")
> Cc: stable@...r.kernel.org
> Signed-off-by: Kyle Tso <kyletso@...gle.com>
> ---
>  drivers/usb/dwc3/core.c   | 25 +++++--------------------
>  drivers/usb/dwc3/core.h   |  4 ++--
>  drivers/usb/dwc3/gadget.c | 19 ++++++++++++++-----
>  3 files changed, 21 insertions(+), 27 deletions(-)

Did this get lost somewhere?  You might need to resend it now that Thinh
is back from vacation.

thanks,

greg k-h