linux-kernel - Re: [PATCH v5 1/3] tty: serial: samsung: Use bit manipulation macros for APPLE_S5L

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7pzwy6ubvcld6zv2amt5s6cctup4du62ysxki5xzfqpys35arc@zbuv4uoht2xm>
Date: Wed, 11 Sep 2024 08:57:07 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Nick Chan <towinchenmi@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, 
	Alim Akhtar <alim.akhtar@...sung.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Jiri Slaby <jirislaby@...nel.org>, linux-arm-kernel@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, 
	asahi@...ts.linux.dev, Janne Grunau <j@...nau.net>, Neal Gompa <neal@...pa.dev>
Subject: Re: [PATCH v5 1/3] tty: serial: samsung: Use bit manipulation macros
 for APPLE_S5L_*

Hi Nick,

On Wed, Sep 11, 2024 at 01:02:11PM GMT, Nick Chan wrote:
> New entries using BIT() will be added soon, so change the existing ones to
> use bit manipulation macros including BIT() and GENMASK() for
> consistency.
> 
> Suggested-by: Krzysztof Kozlowski <krzk@...nel.org>
> Tested-by: Janne Grunau <j@...nau.net>
> Reviewed-by: Neal Gompa <neal@...pa.dev>
> Signed-off-by: Nick Chan <towinchenmi@...il.com>

Thanks for the cleanup!

Reviewed-by: Andi Shyti <andi.shyti@...nel.org>

Andi