linux-kernel - Re: [PATCH v5 2/3] tty: serial: samsung: Fix A7-A11 serial earlycon SError

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <qjlxidd4e7smbr65ebl5mg2pcwv64itz7mgbshxrccp62svfqv@daa3u33m6xx7>
Date: Wed, 11 Sep 2024 08:57:55 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Nick Chan <towinchenmi@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, 
	Alim Akhtar <alim.akhtar@...sung.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Jiri Slaby <jirislaby@...nel.org>, linux-arm-kernel@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, 
	asahi@...ts.linux.dev, Neal Gompa <neal@...pa.dev>, Janne Grunau <j@...nau.net>
Subject: Re: [PATCH v5 2/3] tty: serial: samsung: Fix A7-A11 serial earlycon
 SError

Hi Nick,

On Wed, Sep 11, 2024 at 01:02:12PM GMT, Nick Chan wrote:
> Apple's earlier SoCs, like A7-A11, requires 32-bit writes for the serial
> port. Otherwise, a SError happens when writing to UTXH (+0x20). This only
> manifested in earlycon as reg-io-width in the device tree is consulted
> for normal serial writes.
> 
> Change the iotype of the port to UPIO_MEM32, to allow the serial port to
> function on A7-A11 SoCs. This change does not appear to affect Apple M1 and
> above.
> 
> Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
> Reviewed-by: Neal Gompa <neal@...pa.dev>
> Tested-by: Janne Grunau <j@...nau.net>
> Signed-off-by: Nick Chan <towinchenmi@...il.com>

Reviewed-by: Andi Shyti <andi.shyti@...nel.org>

Andi