linux-kernel - Re: [tip:sched/core 69/70] drivers/cpufreq/cppc_cpufreq.c:227:20: error: use of undeclared identifier 'NSER_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9d838d5-6b3d-4e7c-9bf6-cb2935320467@arm.com>
Date: Wed, 11 Sep 2024 09:15:24 +0100
From: Christian Loehle <christian.loehle@....com>
To: kernel test robot <lkp@...el.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
 x86@...nel.org, Peter Zijlstra <peterz@...radead.org>
Subject: Re: [tip:sched/core 69/70] drivers/cpufreq/cppc_cpufreq.c:227:20:
 error: use of undeclared identifier 'NSER_PER_MSEC'

On 9/10/24 23:20, kernel test robot wrote:
> Hi Christian,
> 
> FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core
> head:   6cbbb91711c6b17da3802a3cf072d3311828ca33
> commit: b3a47ff095544af206b8885391a7bad662d06a57 [69/70] cpufreq/cppc: Use NSEC_PER_MSEC for deadline task
> config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20240911/202409110611.dmyDCkoe-lkp@intel.com/config)
> compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project bf684034844c660b778f0eba103582f582b710c9)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240911/202409110611.dmyDCkoe-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202409110611.dmyDCkoe-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>>> drivers/cpufreq/cppc_cpufreq.c:227:20: error: use of undeclared identifier 'NSER_PER_MSEC'
>      227 |                 .sched_runtime  = NSER_PER_MSEC,
>          |                                   ^
>>> drivers/cpufreq/cppc_cpufreq.c:229:3: error: member reference base type 'long' is not a structure or union
>      228 |                 .sched_deadline = 10 * NSEC_PER_MSEC
>          |                                        ~~~~~~~~~~~~~
>      229 |                 .sched_period   = 10 * NSEC_PER_MSEC,
>          |                 ^~~~~~~~~~~~~
>    2 errors generated.
> 
> 
> vim +/NSER_PER_MSEC +227 drivers/cpufreq/cppc_cpufreq.c
> 
>    215	
>    216	static void __init cppc_freq_invariance_init(void)
>    217	{
>    218		struct sched_attr attr = {
>    219			.size		= sizeof(struct sched_attr),
>    220			.sched_policy	= SCHED_DEADLINE,
>    221			.sched_nice	= 0,
>    222			.sched_priority	= 0,
>    223			/*
>    224			 * Fake (unused) bandwidth; workaround to "fix"
>    225			 * priority inheritance.
>    226			 */
>  > 227			.sched_runtime	= NSER_PER_MSEC,

Sorry, seems I enabled the module, but didn't actually build modules
before sending it out, anyway this should be s/NSER/NSEC

>    228			.sched_deadline = 10 * NSEC_PER_MSEC
and this is missing a comma.
Peter do you mind fixing that up for me?

-->8--

diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
index aff25b598ec4..1a5ad184d28f 100644
--- a/drivers/cpufreq/cppc_cpufreq.c
+++ b/drivers/cpufreq/cppc_cpufreq.c
@@ -224,8 +224,8 @@ static void __init cppc_freq_invariance_init(void)
                 * Fake (unused) bandwidth; workaround to "fix"
                 * priority inheritance.
                 */
-               .sched_runtime  = NSER_PER_MSEC,
-               .sched_deadline = 10 * NSEC_PER_MSEC
+               .sched_runtime  = NSEC_PER_MSEC,
+               .sched_deadline = 10 * NSEC_PER_MSEC,
                .sched_period   = 10 * NSEC_PER_MSEC,
        };
        int ret;