linux-kernel - Re: [PATCH net-next] net: ethtool: phy: Check the req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240911103322.20b7ff57@fedora.home>
Date: Wed, 11 Sep 2024 10:33:22 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com, Andrew Lunn
 <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>,
 linux-arm-kernel@...ts.infradead.org, Christophe Leroy
 <christophe.leroy@...roup.eu>, Herve Codina <herve.codina@...tlin.com>,
 Florian Fainelli <f.fainelli@...il.com>, Heiner Kallweit
 <hkallweit1@...il.com>, Vladimir Oltean <vladimir.oltean@....com>,
 Köry Maincent <kory.maincent@...tlin.com>, Jesse Brandeburg
 <jesse.brandeburg@...el.com>, Marek Behún
 <kabel@...nel.org>, Piergiorgio Beruto <piergiorgio.beruto@...il.com>,
 Oleksij Rempel <o.rempel@...gutronix.de>, Nicolò Veronese
 <nicveronese@...il.com>, Simon Horman <horms@...nel.org>,
 mwojtas@...omium.org, Nathan Chancellor <nathan@...nel.org>, Antoine Tenart
 <atenart@...nel.org>, Marc Kleine-Budde <mkl@...gutronix.de>, Dan Carpenter
 <dan.carpenter@...aro.org>, Romain Gantois <romain.gantois@...tlin.com>
Subject: Re: [PATCH net-next] net: ethtool: phy: Check the req_info.pdn
 field for GET commands

Hi Eric,

On Wed, 11 Sep 2024 09:26:23 +0200
Eric Dumazet <edumazet@...gle.com> wrote:

> On Tue, Sep 10, 2024 at 7:46 PM Maxime Chevallier
> <maxime.chevallier@...tlin.com> wrote:
> >
> > When processing the netlink GET requests to get PHY info, the req_info.pdn
> > pointer is NULL when no PHY matches the requested parameters, such as when
> > the phy_index is invalid, or there's simply no PHY attached to the
> > interface.
> >
> > Therefore, check the req_info.pdn pointer for NULL instead of
> > dereferencing it.
> >
> > Suggested-by: Eric Dumazet <edumazet@...gle.com>
> > Reported-by: Eric Dumazet <edumazet@...gle.com>
> > Closes: https://lore.kernel.org/netdev/CANn89iKRW0WpGAh1tKqY345D8WkYCPm3Y9ym--Si42JZrQAu1g@mail.gmail.com/T/#mfced87d607d18ea32b3b4934dfa18d7b36669285
> > Fixes: 17194be4c8e1 ("net: ethtool: Introduce a command to list PHYs on an interface")
> > Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> > ---  
> 
> Thanks, there is another issue found by syzbot BTW (one imbalanced netdev_put())

Sorry for asking that, but I missed the report from this current patch,
as well as the one you're referring to. I've looked-up the netdev
archive and the syzbot web interface [1] and found no reports for both
issues. I am clearly not looking at the right place, and/or I probably
need to open my eyes a bit more.

Can you point me to the report in question ?

[1] : https://syzkaller.appspot.com/upstream/s/net

> 
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks for the review,

Maxime