[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240912145844.77516-1-m.lobanov@rosalinux.ru>
Date: Thu, 12 Sep 2024 10:58:39 -0400
From: Mikhail Lobanov <m.lobanov@...alinux.ru>
To: Potnuri Bharat Teja <bharat@...lsio.com>
Cc: Mikhail Lobanov <m.lobanov@...alinux.ru>,
Jason Gunthorpe <jgg@...pe.ca>,
Leon Romanovsky <leon@...nel.org>,
Roland Dreier <rolandd@...co.com>,
Steve Wise <larrystevenwise@...il.com>,
linux-rdma@...r.kernel.org,
linux-kernel@...r.kernel.org,
lvc-project@...uxtesting.org
Subject: [PATCH] RDMA/cxgb4: Added NULL check for lookup_atid
The lookup_atid() function can return NULL if the ATID is
invalid or does not exist in the identifier table, which
could lead to dereferencing a null pointer without a
check in the `act_establish()` and `act_open_rpl()` functions.
Add a NULL check to prevent null pointer dereferencing.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: cfdda9d76436 ("RDMA/cxgb4: Add driver for Chelsio T4 RNIC")
Signed-off-by: Mikhail Lobanov <m.lobanov@...alinux.ru>
---
drivers/infiniband/hw/cxgb4/cm.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 040ba2224f9f..311cc5bd160c 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -1223,6 +1223,11 @@ static int act_establish(struct c4iw_dev *dev, struct sk_buff *skb)
ep = lookup_atid(t, atid);
+ if (!ep) {
+ pr_err("Failed to lookup atid %u\n", atid);
+ return -EINVAL;
+ }
+
pr_debug("ep %p tid %u snd_isn %u rcv_isn %u\n", ep, tid,
be32_to_cpu(req->snd_isn), be32_to_cpu(req->rcv_isn));
@@ -2279,6 +2284,12 @@ static int act_open_rpl(struct c4iw_dev *dev, struct sk_buff *skb)
int ret = 0;
ep = lookup_atid(t, atid);
+
+ if (!ep) {
+ pr_err("Failed to lookup atid %u\n", atid);
+ return -EINVAL;
+ }
+
la = (struct sockaddr_in *)&ep->com.local_addr;
ra = (struct sockaddr_in *)&ep->com.remote_addr;
la6 = (struct sockaddr_in6 *)&ep->com.local_addr;
--
2.43.0
Powered by blists - more mailing lists