linux-kernel - Re: [PATCH] RDMA/cxgb4: Added NULL check for lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240916085112.GL4026@unreal>
Date: Mon, 16 Sep 2024 11:51:12 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Mikhail Lobanov <m.lobanov@...alinux.ru>
Cc: Potnuri Bharat Teja <bharat@...lsio.com>,
	Jason Gunthorpe <jgg@...pe.ca>, Roland Dreier <rolandd@...co.com>,
	Steve Wise <larrystevenwise@...il.com>, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] RDMA/cxgb4: Added NULL check for lookup_atid

On Thu, Sep 12, 2024 at 10:58:39AM -0400, Mikhail Lobanov wrote:
> The lookup_atid() function can return NULL if the ATID is
> invalid or does not exist in the identifier table, which
> could lead to dereferencing a null pointer without a
> check in the `act_establish()` and `act_open_rpl()` functions.
> Add a NULL check to prevent null pointer dereferencing.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: cfdda9d76436 ("RDMA/cxgb4: Add driver for Chelsio T4 RNIC")
> Signed-off-by: Mikhail Lobanov <m.lobanov@...alinux.ru>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

I would say that this is not possible flow, but the check is harmless.

Thanks