linux-kernel - Re: [RFC PATCH for-next] pm: cpupower: rename raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5785527a-b259-42ba-989e-978d2e72ff35@linuxfoundation.org>
Date: Thu, 12 Sep 2024 10:31:19 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Min-Hua Chen <minhuadotchen@...il.com>, Thomas Renninger
 <trenn@...e.com>, Shuah Khan <shuah@...nel.org>,
 "John B. Wyatt IV" <jwyatt@...hat.com>, John Kacur <jkacur@...hat.com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [RFC PATCH for-next] pm: cpupower: rename raw_pylibcpupower.i

On 9/12/24 06:50, Min-Hua Chen wrote:
> This RFC patch is actually bug report. All *.i file will be
> removed by 'make mrproper', including raw_pylibcpupower.i, added
> by commit: 338f490e07bc ("pm:cpupower: Add SWIG bindings files for libcpupower")
> 
> We can reproduce the error by performing the following command:
> cd linux-next
> make mrproper
> cd tools/power/cpupower/bindings/python
> make
> 
> We will get an error message:
> make: *** No rule to make target 'raw_pylibcpupower.i', needed by 'raw_pylibcpupower_wrap.c'.  Stop.
> 
> Renaming the raw_pylibcpupower.i is just a workaround to fix the
> issue above.

I need a non-rfc patch for this. Please send a proper patch
I can pull in once John has a chance to review this.

> 
> Signed-off-by: Min-Hua Chen <minhuadotchen@...il.com>
> ---
>   tools/power/cpupower/bindings/python/Makefile                 | 4 ++--
>   .../python/{raw_pylibcpupower.i => raw_pylibcpupower.if}      | 0
>   2 files changed, 2 insertions(+), 2 deletions(-)
>   rename tools/power/cpupower/bindings/python/{raw_pylibcpupower.i => raw_pylibcpupower.if} (100%)
> 
> diff --git a/tools/power/cpupower/bindings/python/Makefile b/tools/power/cpupower/bindings/python/Makefile
> index dc09c5b66ead..de872a1b80d3 100644
> --- a/tools/power/cpupower/bindings/python/Makefile
> +++ b/tools/power/cpupower/bindings/python/Makefile
> @@ -20,13 +20,13 @@ _raw_pylibcpupower.so: raw_pylibcpupower_wrap.o
>   raw_pylibcpupower_wrap.o: raw_pylibcpupower_wrap.c
>   	$(CC) -fPIC -c raw_pylibcpupower_wrap.c $(PY_INCLUDE)
>   
> -raw_pylibcpupower_wrap.c: raw_pylibcpupower.i
> +raw_pylibcpupower_wrap.c: raw_pylibcpupower.if
>   ifeq ($(HAVE_SWIG),0)
>   	$(error "swig was not found. Make sure you have it installed and in the PATH to generate the bindings.")
>   else ifeq ($(HAVE_PYCONFIG),0)
>   	$(error "python-config was not found. Make sure you have it installed and in the PATH to generate the bindings.")
>   endif
> -	swig -python raw_pylibcpupower.i
> +	swig -python raw_pylibcpupower.if
>   
>   # Will only clean the bindings folder; will not clean the actual cpupower folder
>   clean:
> diff --git a/tools/power/cpupower/bindings/python/raw_pylibcpupower.i b/tools/power/cpupower/bindings/python/raw_pylibcpupower.if
> similarity index 100%
> rename from tools/power/cpupower/bindings/python/raw_pylibcpupower.i
> rename to tools/power/cpupower/bindings/python/raw_pylibcpupower.if

thanks,
-- Shuah