linux-kernel - Re: [RFC PATCH for-next] pm: cpupower: rename raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZuMmqAmr62ErjqHc@rhfedora>
Date: Thu, 12 Sep 2024 13:36:40 -0400
From: "John B. Wyatt IV" <jwyatt@...hat.com>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: Min-Hua Chen <minhuadotchen@...il.com>,
	Thomas Renninger <trenn@...e.com>, Shuah Khan <shuah@...nel.org>,
	John Kacur <jkacur@...hat.com>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH for-next] pm: cpupower: rename raw_pylibcpupower.i

On Thu, Sep 12, 2024 at 10:31:19AM -0600, Shuah Khan wrote:
> On 9/12/24 06:50, Min-Hua Chen wrote:
> > This RFC patch is actually bug report. All *.i file will be
> > removed by 'make mrproper', including raw_pylibcpupower.i, added
> > by commit: 338f490e07bc ("pm:cpupower: Add SWIG bindings files for libcpupower")
> > 
> > We can reproduce the error by performing the following command:
> > cd linux-next
> > make mrproper
> > cd tools/power/cpupower/bindings/python
> > make
> > 
> > We will get an error message:
> > make: *** No rule to make target 'raw_pylibcpupower.i', needed by 'raw_pylibcpupower_wrap.c'.  Stop.
> > 
> > Renaming the raw_pylibcpupower.i is just a workaround to fix the
> > issue above.
> 
> I need a non-rfc patch for this. Please send a proper patch
> I can pull in once John has a chance to review this.

I have reviewed and tested and this. I am good with it being a stopgap.

Please send the non-rfc patch.

Thank you for reporting and sending a patch for this Min-Hua.

Reviewed-by: John B. Wyatt IV <jwyatt@...hat.com>
Reviewed-by: John B. Wyatt IV <sageofredondo@...il.com>
Tested-by: John B. Wyatt IV <jwyatt@...hat.com>
Tested-by: John B. Wyatt IV <sageofredondo@...il.com>

-- 
Sincerely,
John Wyatt
Software Engineer, Core Kernel
Red Hat