linux-kernel - Re: [PATCH v2] timekeeping: move multigrain timestamp floor handling into timekeeper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANDhNCrfzMZj8T-mCKd9RAF4D6-EBAtmkffvP5-WMJbgQHdztw@mail.gmail.com>
Date: Thu, 12 Sep 2024 13:15:49 -0700
From: John Stultz <jstultz@...gle.com>
To: Jeff Layton <jlayton@...nel.org>
Cc: Alexander Viro <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>, 
	Thomas Gleixner <tglx@...utronix.de>, Stephen Boyd <sboyd@...nel.org>, Arnd Bergmann <arnd@...nel.org>, 
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel test robot <oliver.sang@...el.com>
Subject: Re: [PATCH v2] timekeeping: move multigrain timestamp floor handling
 into timekeeper

On Thu, Sep 12, 2024 at 1:11 PM John Stultz <jstultz@...gle.com> wrote:
> So initially I was expecting this to look something like (sorry for
> the whitespace damage here):
> {
>     do {
>         seq = read_seqcount_begin(&tk_core.seq);
>         ts->tv_sec = tk->xtime_sec;
>         mono = tk->tkr_mono.base;
>         nsecs = timekeeping_get_ns(&tk->tkr_mono);
>         offset = *offsets[TK_OFFS_REAL];
>     } while (read_seqcount_retry(&tk_core.seq, seq));
>
>     mono = ktime_add_ns(mono, nsecs);
>     do {
>         old = atomic64_read(&mg_floor);
>         if (floor >= mono)
>             break;

Apologies, that should be
         if (old >= mono)
             break;

thanks
-john