linux-kernel - Re: [PATCH v2 2/4] LoongArch: cpu-probe: Move IOCSR probing out of cpu_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4f631f4a-eeb8-4b57-8424-4f5e970f0b69@app.fastmail.com>
Date: Thu, 12 Sep 2024 21:59:00 +0100
From: "Jiaxun Yang" <jiaxun.yang@...goat.com>
To: "Huacai Chen" <chenhuacai@...nel.org>, "Xuerui Wang" <kernel@...0n.name>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 "Viresh Kumar" <viresh.kumar@...aro.org>,
 "Thomas Gleixner" <tglx@...utronix.de>,
 "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>
Cc: loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org,
 "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
 kvm@...r.kernel.org
Subject: Re: [PATCH v2 2/4] LoongArch: cpu-probe: Move IOCSR probing out of
 cpu_probe_common

在2024年9月12日九月 下午9:55，Jiaxun Yang写道：
[...]
> +
> +	if (c->options & LOONGARCH_CPU_IOCSR)
> +		return;
Oops, typo here, there should be a not :-(

Huacai, if the series is ok for you please fix this when applying
the patch. I only tested against NEMU so didn't catch this :-(

Thanks
- Jiaxun

> +
> +	*vendor = iocsr_read64(LOONGARCH_IOCSR_VENDOR);
> +	*cpuname = iocsr_read64(LOONGARCH_IOCSR_CPUNAME);
> +
> +	if (!__cpu_full_name[cpu])
> +		__cpu_full_name[cpu] = cpu_full_name;
> +
> +	config = iocsr_read32(LOONGARCH_IOCSR_FEATURES);
> +	if (config & IOCSRF_CSRIPI)
> +		c->options |= LOONGARCH_CPU_CSRIPI;
> +	if (config & IOCSRF_EXTIOI)
> +		c->options |= LOONGARCH_CPU_EXTIOI;
> +	if (config & IOCSRF_FREQSCALE)
> +		c->options |= LOONGARCH_CPU_SCALEFREQ;
> +	if (config & IOCSRF_FLATMODE)
> +		c->options |= LOONGARCH_CPU_FLATMODE;
> +	if (config & IOCSRF_EIODECODE)
> +		c->options |= LOONGARCH_CPU_EIODECODE;
> +	if (config & IOCSRF_AVEC)
> +		c->options |= LOONGARCH_CPU_AVECINT;
> +	if (config & IOCSRF_VM)
> +		c->options |= LOONGARCH_CPU_HYPERVISOR;
>  }
> 
>  #ifdef CONFIG_64BIT
>
> -- 
> 2.46.0

-- 
- Jiaxun