linux-kernel - Re: [PATCH v1 00/12] i2c: isch: Put the driver into shape

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4gdk4ktbfbgd4r7rf75o2vr5f6wtw335ywjaec6hiqua2rl27n@mgpevcixnz27>
Date: Thu, 12 Sep 2024 09:33:40 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Jean Delvare <jdelvare@...e.com>
Subject: Re: [PATCH v1 00/12] i2c: isch: Put the driver into shape

Hi Andy,

> Andy Shevchenko (12):
>   i2c: isch: Add missed 'else'
>   i2c: isch: Pass pointer to struct i2c_adapter down
>   i2c: isch: Use string_choices API instead of ternary operator
>   i2c: isch: Switch to memory mapped IO accessors
>   i2c: isch: Use custom private data structure
>   i2c: isch: switch i2c registration to devm functions
>   i2c: isch: Utilize temporary variable to hold device pointer
>   i2c: isch: Use read_poll_timeout()
>   i2c: isch: Unify the name of the variable to hold an error code
>   i2c: isch: Don't use "proxy" headers
>   i2c: isch: Prefer to use octal permission
>   i2c: isch: Convert to kernel-doc

very nice cleanup! Now this driver has a nice modern look.
Thanks!

I will leave this patch for some time to give it some more time
for review and then I will take it in.

Thanks,
Andi