linux-kernel - Re: [PATCH v7 00/21] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1691f16c-af41-4b38-bd5e-38af0e7a2c99@gmail.com>
Date: Thu, 12 Sep 2024 10:28:32 +0800
From: Alex Shi <seakeel@...il.com>
To: Vishal Moola <vishal.moola@...il.com>
Cc: alexs@...nel.org, Vitaly Wool <vitaly.wool@...sulko.com>,
 Miaohe Lin <linmiaohe@...wei.com>, Andrew Morton
 <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, minchan@...nel.org, willy@...radead.org,
 senozhatsky@...omium.org, david@...hat.com, 42.hyeyoo@...il.com,
 Yosry Ahmed <yosryahmed@...gle.com>, nphamcs@...il.com
Subject: Re: [PATCH v7 00/21] mm/zsmalloc: add zpdesc memory descriptor for
 zswap.zpool



On 9/5/24 4:04 AM, Vishal Moola wrote:
> On Wed, Sep 04, 2024 at 02:54:14PM +0800, Alex Shi wrote:
>>
>>
>> On 9/2/24 3:21 PM, alexs@...nel.org wrote:
>>> From: Alex Shi <alexs@...nel.org>
>>>
>> ...
>>
>>>
>>> This patchset abstracts the memory descriptor used in zsmalloc by zswap/zram.
>>> The descriptor still overlays the struct page; nothing has changed
>>> in that regard. What this patchset accomplishes is the use of folios in
>>> to save some code size, and the introduction of a new concept, zpdesc. 
>>> This patchset is just an initial step; it does not bias the potential 
>>> changes to kmem_alloc or larger zspage modifications.
>>>
>> ...
>>>
>>> Thanks a lot for comments and suggestion from Yosry, Yoo, Sergey, Willy
>>> and Vishal!
>>>
>>
>> This patchset could save 6.3% code size, and it's a nice abstract of zsmalloc
>> memory usage.
>> Is there any more comments, or mind to give a reviewed-by?
> 
> Please CC me on future versions. Most of the zsmalloc conversions seem
> ok, but I'd hold off on further iterations of the descriptor patches until
> the maintainers decide on what/how this descriptor will be used
> (i.e. our end goals).

Thanks for your care.

Is there some places or some conversion should be changed?

btw, the descriptor is used now and could save a few code size. :)

Thanks