linux-kernel - Re: [PATCH v3 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a7d017a-8317-462b-8698-03cc7099a74f@classfun.cn>
Date: Thu, 12 Sep 2024 21:53:42 +0800
From: Junhao Xie <bigfoot@...ssfun.cn>
To: Chukun Pan <amadeus@....edu.cn>
Cc: conor+dt@...nel.org, devicetree@...r.kernel.org, dsimic@...jaro.org,
 heiko@...ech.de, jonas@...boo.se, krzk+dt@...nel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-rockchip@...ts.infradead.org, Junhao Xie <bigfoot@...ssfun.cn>
Subject: Re: [PATCH v3 3/3] arm64: dts: rockchip: add dts for Ariaboard
 Photonicat RK3568

On 2024/9/12 10:30, Chukun Pan wrote:
> Hi Junhao,
> 
>> ...
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
>> ...
> 
>> +	rfkill-modem {
>> +		compatible = "rfkill-gpio";
>> +		label = "M.2 USB Modem";
>> +		radio-type = "wwan";
>> +		reset-gpios = <&gpio0 RK_PB0 GPIO_ACTIVE_LOW>;
>> +		shutdown-gpios = <&gpio4 RK_PC4 GPIO_ACTIVE_HIGH>;
>> +	};
> 
> gpio0 RK_PB0 conflicts with xin32k, please add:
> 
> &xin32k {
> 	pinctrl-names = "default";
> 	pinctrl-0 = <&clk32k_out1>;
> };

I added it and it currently works fine

> 
>> +	vccin_5v: regulator-5v0-vcc-in {
>> +	vcc_sysin: regulator-5v0-vcc-sysin {
>> +	vcc_syson: regulator-5v0-vcc-syson {
>> +	vcc5v0_usb30_otg0: regulator-5v0-vcc-usb-host {
> 
> obviously (

I seem to have misunderstood the rules in dt-bindings before.
The following looks better:

vcc5v0_usb30_otg0: regulator-vcc5v0-usb30-otg0 {
vccin_5v: regulator-vccin-5v {
vcc_sysin: regulator-vcc-sysin {
vcc_syson: regulator-vcc-syson {

> 

Thanks for your review, I will fix all problems in next version!

Best regards,
Junhao