linux-kernel - Re: [PATCH v3 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240912023018.23986-1-amadeus@jmu.edu.cn>
Date: Thu, 12 Sep 2024 10:30:18 +0800
From: Chukun Pan <amadeus@....edu.cn>
To: bigfoot@...ssfun.cn
Cc: amadeus@....edu.cn,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	dsimic@...jaro.org,
	heiko@...ech.de,
	jonas@...boo.se,
	krzk+dt@...nel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v3 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568

Hi Junhao,

> ...
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
> ...

> +	rfkill-modem {
> +		compatible = "rfkill-gpio";
> +		label = "M.2 USB Modem";
> +		radio-type = "wwan";
> +		reset-gpios = <&gpio0 RK_PB0 GPIO_ACTIVE_LOW>;
> +		shutdown-gpios = <&gpio4 RK_PC4 GPIO_ACTIVE_HIGH>;
> +	};

gpio0 RK_PB0 conflicts with xin32k, please add:

&xin32k {
	pinctrl-names = "default";
	pinctrl-0 = <&clk32k_out1>;
};

> +	vccin_5v: regulator-5v0-vcc-in {
> +	vcc_sysin: regulator-5v0-vcc-sysin {
> +	vcc_syson: regulator-5v0-vcc-syson {
> +	vcc5v0_usb30_otg0: regulator-5v0-vcc-usb-host {

obviously (

-- 
2.25.1