linux-kernel - Re: [PATCH V22 17/22] mmc: sdhci-uhs2: add irq() and others

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <973892ec-d905-4524-a024-d506099290ea@web.de>
Date: Fri, 13 Sep 2024 17:17:17 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Akashi Takahiro <takahiro.akashi@...aro.org>,
 Ben Chuang <ben.chuang@...esyslogic.com.tw>,
 Victor Shih <victor.shih@...esyslogic.com.tw>, linux-mmc@...r.kernel.org,
 Adrian Hunter <adrian.hunter@...el.com>, Ulf Hansson <ulf.hansson@...aro.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Ben Chuang <benchuanggli@...il.com>,
 Daniil Lunev <dlunev@...omium.org>, Greg Tu <greg.tu@...esyslogic.com.tw>,
 HL.Liu@...esyslogic.com.tw, Lucas Lai <Lucas.Lai@...esyslogic.com.tw>
Subject: Re: [PATCH V22 17/22] mmc: sdhci-uhs2: add irq() and others

…
> +++ b/drivers/mmc/host/sdhci-uhs2.c
…
> +static bool sdhci_uhs2_request_done(struct sdhci_host *host)
> +{
…
> +	int i;
> +
> +	spin_lock_irqsave(&host->lock, flags);
…
> +	host->mrqs_done[i] = NULL;
> +
> +	spin_unlock_irqrestore(&host->lock, flags);
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&host->lock);”?
https://elixir.bootlin.com/linux/v6.11-rc7/source/include/linux/spinlock.h#L572

Regards,
Markus