linux-kernel - Re: [PATCH] ACPI: thermal: Use strscpy() instead of strcpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4e7b3ac-d8fa-47b9-84f6-e3332bb54e12@wanadoo.fr>
Date: Fri, 13 Sep 2024 21:31:57 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Abdul Rahim <abdul.rahim@...ahoo.com>, rafael@...nel.org,
 rui.zhang@...el.com, lenb@...nel.org
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: thermal: Use strscpy() instead of strcpy()

Le 13/09/2024 à 21:12, Abdul Rahim a écrit :
> strcpy() is generally considered unsafe and use of strscpy() is
> recommended [1]
> 
> this fixes checkpatch warning:
>      WARNING: Prefer strscpy over strcpy
> 
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
> Signed-off-by: Abdul Rahim <abdul.rahim@...ahoo.com>

Hi,

in order to ease the review process, when you send a new version of a 
patch, the subject line should state the version: (i.e.: [PATCH v2] ...)


It is also a good practice to explain what has changed with the previous 
version.
Finally, it is nice to provide the link on lore to the previous version.
All this should added below the first ---.
Here it could look like:

> ---

Changes in v2:
   - Remove an unneeded extra parameter (MAX_ACPI_DEVICE_NAME_LEN) in 
the 2nd strscpy() call

v1: 
https://lore.kernel.org/all/20240912205922.302036-1-abdul.rahim@myyahoo.com/

CJ

>   drivers/acpi/thermal.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> index 78db38c7076e..6671537cb4b7 100644
> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -796,9 +796,9 @@ static int acpi_thermal_add(struct acpi_device *device)
>   		return -ENOMEM;
>   
>   	tz->device = device;
> -	strcpy(tz->name, device->pnp.bus_id);
> -	strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
> -	strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
> +	strscpy(tz->name, device->pnp.bus_id);
> +	strscpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
> +	strscpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
>   	device->driver_data = tz;
>   
>   	acpi_thermal_aml_dependency_fix(tz);