linux-kernel - Re: [PATCH] ACPI: thermal: Use strscpy() instead of strcpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <pjfihdom7drxw5jse7kd2w5umjavlu5vb7v2p3svwz4eymqfkf@artgu4pefe5k>
Date: Sat, 14 Sep 2024 02:53:17 +0530
From: Abdul Rahim <abdul.rahim@...ahoo.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: rafael@...nel.org, rui.zhang@...el.com, lenb@...nel.org, 
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: thermal: Use strscpy() instead of strcpy()

On Fri, Sep 13, 2024 at 09:31:57PM GMT, Christophe JAILLET wrote:
> Le 13/09/2024 ï¿½ 21:12, Abdul Rahim a ï¿½critï¿½:
> > strcpy() is generally considered unsafe and use of strscpy() is
> > recommended [1]
> > 
> > this fixes checkpatch warning:
> >      WARNING: Prefer strscpy over strcpy
> > 
> > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
> > Signed-off-by: Abdul Rahim <abdul.rahim@...ahoo.com>
> 
> Hi,
> 
> in order to ease the review process, when you send a new version of a patch,
> the subject line should state the version: (i.e.: [PATCH v2] ...)
> 
> 
> It is also a good practice to explain what has changed with the previous
> version.
> Finally, it is nice to provide the link on lore to the previous version.
> All this should added below the first ---.
> Here it could look like:
> 
> > ---
> 
> Changes in v2:
>   - Remove an unneeded extra parameter (MAX_ACPI_DEVICE_NAME_LEN) in the 2nd
> strscpy() call
> 
> v1:
> https://lore.kernel.org/all/20240912205922.302036-1-abdul.rahim@myyahoo.com/
> 
> CJ
> 
> >   drivers/acpi/thermal.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> > index 78db38c7076e..6671537cb4b7 100644
> > --- a/drivers/acpi/thermal.c
> > +++ b/drivers/acpi/thermal.c
> > @@ -796,9 +796,9 @@ static int acpi_thermal_add(struct acpi_device *device)
> >   		return -ENOMEM;
> >   	tz->device = device;
> > -	strcpy(tz->name, device->pnp.bus_id);
> > -	strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
> > -	strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
> > +	strscpy(tz->name, device->pnp.bus_id);
> > +	strscpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
> > +	strscpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
> >   	device->driver_data = tz;
> >   	acpi_thermal_aml_dependency_fix(tz);
> 
> 

Thanks CJ,

https://lore.kernel.org/all/20240913211156.103864-1-abdul.rahim@myyahoo.com/