linux-kernel - Re: [PATCH v3 1/2] staging: vt6655: Rename variable apTD0Rings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ccf9206-50de-41d4-ba7b-ce5a97fdd69e@gmail.com>
Date: Fri, 13 Sep 2024 07:08:47 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Xingquan Liu <b1n@....io>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] staging: vt6655: Rename variable apTD0Rings

On 9/13/24 03:23, Xingquan Liu wrote:
> Rename variable apTD0Rings to ap_td0_rings to fix checkpatch warning
> Avoid CamelCase.
> 
> Signed-off-by: Xingquan Liu <b1n@....io>
> ---
> v3: Add change history
> v2: Rename variable apTD1Rings
> 
>   drivers/staging/vt6655/card.c        |  6 +++---
>   drivers/staging/vt6655/device.h      |  2 +-
>   drivers/staging/vt6655/device_main.c | 14 +++++++-------
>   3 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index 688c870d89bc..36bf8cde2e08 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -388,8 +388,8 @@ void card_safe_reset_tx(struct vnt_private *priv)
>   	struct vnt_tx_desc *curr_td;
>   
>   	/* initialize TD index */
> -	priv->tail_td[0] = &priv->apTD0Rings[0];
> -	priv->apCurrTD[0] = &priv->apTD0Rings[0];
> +	priv->tail_td[0] = &priv->ap_td0_rings[0];
> +	priv->apCurrTD[0] = &priv->ap_td0_rings[0];
>   
>   	priv->tail_td[1] = &priv->apTD1Rings[0];
>   	priv->apCurrTD[1] = &priv->apTD1Rings[0];
> @@ -398,7 +398,7 @@ void card_safe_reset_tx(struct vnt_private *priv)
>   		priv->iTDUsed[uu] = 0;
>   
>   	for (uu = 0; uu < priv->opts.tx_descs[0]; uu++) {
> -		curr_td = &priv->apTD0Rings[uu];
> +		curr_td = &priv->ap_td0_rings[uu];
>   		curr_td->td0.owner = OWNED_BY_HOST;
>   		/* init all Tx Packet pointer to NULL */
>   	}
> diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> index 32d9cbd55222..32c51d794264 100644
> --- a/drivers/staging/vt6655/device.h
> +++ b/drivers/staging/vt6655/device.h
> @@ -135,7 +135,7 @@ struct vnt_private {
>   	struct vnt_tx_desc *apCurrTD[TYPE_MAXTD];
>   	struct vnt_tx_desc *tail_td[TYPE_MAXTD];
>   
> -	struct vnt_tx_desc *apTD0Rings;
> +	struct vnt_tx_desc *ap_td0_rings;
>   	struct vnt_tx_desc *apTD1Rings;
>   
>   	struct vnt_rx_desc *aRD0Ring;
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 9ea647aefd60..a8dcd8ad3945 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -550,7 +550,7 @@ static bool device_init_rings(struct vnt_private *priv)
>   		priv->opts.tx_descs[0] * sizeof(struct vnt_tx_desc);
>   
>   	/* vir_pool: pvoid type */
> -	priv->apTD0Rings = vir_pool
> +	priv->ap_td0_rings = vir_pool
>   		+ priv->opts.rx_descs0 * sizeof(struct vnt_rx_desc)
>   		+ priv->opts.rx_descs1 * sizeof(struct vnt_rx_desc);
>   
> @@ -720,7 +720,7 @@ static int device_init_td0_ring(struct vnt_private *priv)
>   	curr = priv->td0_pool_dma;
>   	for (i = 0; i < priv->opts.tx_descs[0];
>   	     i++, curr += sizeof(struct vnt_tx_desc)) {
> -		desc = &priv->apTD0Rings[i];
> +		desc = &priv->ap_td0_rings[i];
>   		desc->td_info = kzalloc(sizeof(*desc->td_info), GFP_KERNEL);
>   		if (!desc->td_info) {
>   			ret = -ENOMEM;
> @@ -730,20 +730,20 @@ static int device_init_td0_ring(struct vnt_private *priv)
>   		desc->td_info->buf = priv->tx0_bufs + i * PKT_BUF_SZ;
>   		desc->td_info->buf_dma = priv->tx_bufs_dma0 + i * PKT_BUF_SZ;
>   
> -		desc->next = &(priv->apTD0Rings[(i + 1) % priv->opts.tx_descs[0]]);
> +		desc->next = &(priv->ap_td0_rings[(i + 1) % priv->opts.tx_descs[0]]);
>   		desc->next_desc = cpu_to_le32(curr +
>   					      sizeof(struct vnt_tx_desc));
>   	}
>   
>   	if (i > 0)
> -		priv->apTD0Rings[i - 1].next_desc = cpu_to_le32(priv->td0_pool_dma);
> -	priv->tail_td[0] = priv->apCurrTD[0] = &priv->apTD0Rings[0];
> +		priv->ap_td0_rings[i - 1].next_desc = cpu_to_le32(priv->td0_pool_dma);
> +	priv->tail_td[0] = priv->apCurrTD[0] = &priv->ap_td0_rings[0];
>   
>   	return 0;
>   
>   err_free_desc:
>   	while (i--) {
> -		desc = &priv->apTD0Rings[i];
> +		desc = &priv->ap_td0_rings[i];
>   		kfree(desc->td_info);
>   	}
>   
> @@ -795,7 +795,7 @@ static void device_free_td0_ring(struct vnt_private *priv)
>   	int i;
>   
>   	for (i = 0; i < priv->opts.tx_descs[0]; i++) {
> -		struct vnt_tx_desc *desc = &priv->apTD0Rings[i];
> +		struct vnt_tx_desc *desc = &priv->ap_td0_rings[i];
>   		struct vnt_td_info *td_info = desc->td_info;
>   
>   		dev_kfree_skb(td_info->skb);

Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>