linux-kernel - Re: [PATCH v3 9/9] mm: Consolidate common checks in hugetlb_get_unmapped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202409131650.lUO7EoXP-lkp@intel.com>
Date: Fri, 13 Sep 2024 16:51:44 +0800
From: kernel test robot <lkp@...el.com>
To: Oscar Salvador <osalvador@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc: oe-kbuild-all@...ts.linux.dev,
	Linux Memory Management List <linux-mm@...ck.org>,
	linux-kernel@...r.kernel.org, Peter Xu <peterx@...hat.com>,
	Muchun Song <muchun.song@...ux.dev>,
	David Hildenbrand <david@...hat.com>,
	Donet Tom <donettom@...ux.ibm.com>,
	Vlastimil Babka <vbabka@...e.cz>, Michal Hocko <mhocko@...e.com>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	"Liam R . Howlett" <Liam.Howlett@...cle.com>,
	Oscar Salvador <osalvador@...e.de>
Subject: Re: [PATCH v3 9/9] mm: Consolidate common checks in
 hugetlb_get_unmapped_area

Hi Oscar,

kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on next-20240912]
[cannot apply to s390/features powerpc/next powerpc/fixes deller-parisc/for-next arnd-asm-generic/master linus/master v6.11-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Oscar-Salvador/mm-mmap-Teach-generic_get_unmapped_area-_topdown-to-handle-hugetlb-mappings/20240910-160312
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20240910080030.1272373-10-osalvador%40suse.de
patch subject: [PATCH v3 9/9] mm: Consolidate common checks in hugetlb_get_unmapped_area
config: loongarch-randconfig-002-20240913 (https://download.01.org/0day-ci/archive/20240913/202409131650.lUO7EoXP-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240913/202409131650.lUO7EoXP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409131650.lUO7EoXP-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/linux/hugetlb.h:792,
                    from include/linux/migrate.h:8,
                    from fs/aio.c:40:
   arch/loongarch/include/asm/hugetlb.h: In function 'prepare_hugepage_range':
>> arch/loongarch/include/asm/hugetlb.h:19:24: warning: unused variable 'h' [-Wunused-variable]
      19 |         struct hstate *h = hstate_file(file);
         |                        ^


vim +/h +19 arch/loongarch/include/asm/hugetlb.h

09cfefb7fa70c3 Huacai Chen 2022-05-31  12  
09cfefb7fa70c3 Huacai Chen 2022-05-31  13  #define __HAVE_ARCH_PREPARE_HUGEPAGE_RANGE
09cfefb7fa70c3 Huacai Chen 2022-05-31  14  static inline int prepare_hugepage_range(struct file *file,
09cfefb7fa70c3 Huacai Chen 2022-05-31  15  					 unsigned long addr,
09cfefb7fa70c3 Huacai Chen 2022-05-31  16  					 unsigned long len)
09cfefb7fa70c3 Huacai Chen 2022-05-31  17  {
09cfefb7fa70c3 Huacai Chen 2022-05-31  18  	unsigned long task_size = STACK_TOP;
09cfefb7fa70c3 Huacai Chen 2022-05-31 @19  	struct hstate *h = hstate_file(file);
09cfefb7fa70c3 Huacai Chen 2022-05-31  20  
09cfefb7fa70c3 Huacai Chen 2022-05-31  21  	if (len > task_size)
09cfefb7fa70c3 Huacai Chen 2022-05-31  22  		return -ENOMEM;
09cfefb7fa70c3 Huacai Chen 2022-05-31  23  	if (task_size - len < addr)
09cfefb7fa70c3 Huacai Chen 2022-05-31  24  		return -EINVAL;
09cfefb7fa70c3 Huacai Chen 2022-05-31  25  	return 0;
09cfefb7fa70c3 Huacai Chen 2022-05-31  26  }
09cfefb7fa70c3 Huacai Chen 2022-05-31  27  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki