linux-kernel - Re: [PATCH v3 4/9] arch/sparc: Teach arch_get_unmapped_area{

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202409131805.4Dlb536A-lkp@intel.com>
Date: Fri, 13 Sep 2024 19:16:52 +0800
From: kernel test robot <lkp@...el.com>
To: Oscar Salvador <osalvador@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc: oe-kbuild-all@...ts.linux.dev,
	Linux Memory Management List <linux-mm@...ck.org>,
	linux-kernel@...r.kernel.org, Peter Xu <peterx@...hat.com>,
	Muchun Song <muchun.song@...ux.dev>,
	David Hildenbrand <david@...hat.com>,
	Donet Tom <donettom@...ux.ibm.com>,
	Vlastimil Babka <vbabka@...e.cz>, Michal Hocko <mhocko@...e.com>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	"Liam R . Howlett" <Liam.Howlett@...cle.com>,
	Oscar Salvador <osalvador@...e.de>
Subject: Re: [PATCH v3 4/9] arch/sparc: Teach
 arch_get_unmapped_area{_topdown} to handle hugetlb mappings

Hi Oscar,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on next-20240913]
[cannot apply to s390/features powerpc/next powerpc/fixes deller-parisc/for-next arnd-asm-generic/master linus/master v6.11-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Oscar-Salvador/mm-mmap-Teach-generic_get_unmapped_area-_topdown-to-handle-hugetlb-mappings/20240910-160312
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20240910080030.1272373-5-osalvador%40suse.de
patch subject: [PATCH v3 4/9] arch/sparc: Teach arch_get_unmapped_area{_topdown} to handle hugetlb mappings
config: sparc-randconfig-002-20240913 (https://download.01.org/0day-ci/archive/20240913/202409131805.4Dlb536A-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240913/202409131805.4Dlb536A-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409131805.4Dlb536A-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/sparc/kernel/sys_sparc_32.c: In function 'arch_get_unmapped_area':
>> arch/sparc/kernel/sys_sparc_32.c:55:22: error: 'file_huge_pages' undeclared (first use in this function); did you mean 'file_hugepage'?
      55 |                 if (!file_huge_pages && (flags & MAP_SHARED) &&
         |                      ^~~~~~~~~~~~~~~
         |                      file_hugepage
   arch/sparc/kernel/sys_sparc_32.c:55:22: note: each undeclared identifier is reported only once for each function it appears in


vim +55 arch/sparc/kernel/sys_sparc_32.c

    42	
    43	unsigned long arch_get_unmapped_area(struct file *filp, unsigned long addr, unsigned long len, unsigned long pgoff, unsigned long flags, vm_flags_t vm_flags)
    44	{
    45		struct vm_unmapped_area_info info = {};
    46		bool file_hugepage = false;
    47	
    48		if (filp && is_file_hugepages(filp))
    49			file_hugepage = true;
    50	
    51		if (flags & MAP_FIXED) {
    52			/* We do not accept a shared mapping if it would violate
    53			 * cache aliasing constraints.
    54			 */
  > 55			if (!file_huge_pages && (flags & MAP_SHARED) &&
    56			    ((addr - (pgoff << PAGE_SHIFT)) & (SHMLBA - 1)))
    57				return -EINVAL;
    58			return addr;
    59		}
    60	
    61		/* See asm-sparc/uaccess.h */
    62		if (len > TASK_SIZE - PAGE_SIZE)
    63			return -ENOMEM;
    64		if (!addr)
    65			addr = TASK_UNMAPPED_BASE;
    66	
    67		info.length = len;
    68		info.low_limit = addr;
    69		info.high_limit = TASK_SIZE;
    70		if (!file_hugepage) {
    71			info.align_mask = (flags & MAP_SHARED) ?
    72				(PAGE_MASK & (SHMLBA - 1)) : 0;
    73			info.align_offset = pgoff << PAGE_SHIFT;
    74		} else {
    75			info.align_mask = huge_page_mask_align(filp);
    76		}
    77		return vm_unmapped_area(&info);
    78	}
    79	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki