linux-kernel - Re: [PATCH net-next V2 4/5] net: lan743x: Implement phylink pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZuP9y+5YntuUJNTe@HYD-DK-UNGSW21.microchip.com>
Date: Fri, 13 Sep 2024 14:24:35 +0530
From: Raju Lakkaraju - I30499 <Raju.Lakkaraju@...rochip.com>
To: Ronnie Kunin - C21729 <Ronnie.Kunin@...rochip.com>
CC: Andrew Lunn <andrew@...n.ch>, Raju Lakkaraju - I30499
	<Raju.Lakkaraju@...rochip.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "Bryan Whitehead
 - C21958" <Bryan.Whitehead@...rochip.com>, UNGLinuxDriver
	<UNGLinuxDriver@...rochip.com>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "maxime.chevallier@...tlin.com"
	<maxime.chevallier@...tlin.com>, "rdunlap@...radead.org"
	<rdunlap@...radead.org>, Steen Hegelund - M31857
	<Steen.Hegelund@...rochip.com>, Daniel Machon - M70577
	<Daniel.Machon@...rochip.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next V2 4/5] net: lan743x: Implement phylink pcs

Hi Andrew / Ronnie,

The 09/12/2024 16:04, Ronnie Kunin - C21729 wrote:
> 
> 
> > -----Original Message-----
> > From: Andrew Lunn <andrew@...n.ch>
> > Sent: Thursday, September 12, 2024 11:28 AM
> > To: Raju Lakkaraju - I30499 <Raju.Lakkaraju@...rochip.com>
> > Cc: netdev@...r.kernel.org; davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> > pabeni@...hat.com; Bryan Whitehead - C21958 <Bryan.Whitehead@...rochip.com>; UNGLinuxDriver
> > <UNGLinuxDriver@...rochip.com>; linux@...linux.org.uk; maxime.chevallier@...tlin.com;
> > rdunlap@...radead.org; Steen Hegelund - M31857 <Steen.Hegelund@...rochip.com>; Daniel Machon -
> > M70577 <Daniel.Machon@...rochip.com>; linux-kernel@...r.kernel.org
> > Subject: Re: [PATCH net-next V2 4/5] net: lan743x: Implement phylink pcs
> > 
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > > > Also, am i reading this correct. C22 transfers will go out a
> > > > completely different bus to C45 transfers when there is an SFP?
> > >
> > > No. You are correct.
> > > This LAN743x driver support following chips 1. LAN7430 - C22 only with
> > > GMII/RGMII I/F 2. LAN7431 - C22 only with MII I/F
> > 
> > Fine, simple, not a problem.
> > 
> > > 3. PCI11010/PCI11414 - C45 with RGMII or SGMII/1000Base-X/2500Base-X
> > >    If SFP enable, then XPCS's C45 PCS access
> > >    If SGMII only enable, then SGMII (PCS) C45 access
> > 
> > Physically, there are two MDIO busses? There is an external MDIO bus with two pins along side the
> > RGMII/SGMII pins? And internally, there is an MDIO bus to the PCS block?
> > 
> > Some designs do have only one bus, the internal PCS uses address X on the bus and you are simply not
> > allowed to put an external device at that address.
> > 
> > But from my reading of the code, you have two MDIO busses, so you need two Linux MDIO busses.
> > 
> >         Andrew
> 
> Our PCI11x1x hardware has a single MDIO controller that gets used regardless of whether the chip interface is set to RGMII or to SGMII/BASE-X.
> When we are using an SFP, the MDIO lines from our controller are not used / connected at all to the SFP.
> 
> Raju can probably explain this way better than me since the how all this interaction in the linux mdio/sfp/xpcs frameworks work honestly goes over my head. From what he told me even when we are not using our mdio controller lines, since there is indirect access to the PHY (the one inside of the SFP) via the I2C controller (which btw does not share any hardware pins with those used by the MDIO controller), he had to change the PHY management functions for that indirect access to be used when SFP is selected.
> 
> Ronnie

It's my mistake. We don't need 2 MDIO buses. 
If SFP present, XPC's MDIO bus can use,
If not sfp, LAN743x MDIO bus can use. 

We will fix.

> 

-- 
Thanks,                                                                         
Raju