linux-kernel - Re: [PATCH v1] watchdog: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240913083637.GA31468@www.linux-watchdog.org>
Date: Fri, 13 Sep 2024 10:36:37 +0200
From: Wim Van Sebroeck <wim@...ux-watchdog.org>
To: Shen Lichuan <shenlichuan@...o.com>
Cc: wim@...ux-watchdog.org, linux@...ck-us.net,
	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
	opensource.kernel@...o.com
Subject: Re: [PATCH v1] watchdog: Convert comma to semicolon

Hi Shen,

> To ensure code clarity and prevent potential errors, it's advisable
> to employ the ';' as a statement separator, except when ',' are
> intentionally used for specific purposes.
> 
> Signed-off-by: Shen Lichuan <shenlichuan@...o.com>
> ---
>  drivers/watchdog/iTCO_wdt.c   | 4 ++--
>  drivers/watchdog/pm8916_wdt.c | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
> index 264857d314da..35b358bcf94c 100644
> --- a/drivers/watchdog/iTCO_wdt.c
> +++ b/drivers/watchdog/iTCO_wdt.c
> @@ -563,8 +563,8 @@ static int iTCO_wdt_probe(struct platform_device *pdev)
>  	}
>  
>  	ident.firmware_version = p->iTCO_version;
> -	p->wddev.info = &ident,
> -	p->wddev.ops = &iTCO_wdt_ops,
> +	p->wddev.info = &ident;
> +	p->wddev.ops = &iTCO_wdt_ops;
>  	p->wddev.bootstatus = 0;
>  	p->wddev.timeout = WATCHDOG_TIMEOUT;
>  	watchdog_set_nowayout(&p->wddev, nowayout);

Removed this part since there was allready a patch for this that is in linux-watchdog-next.

> diff --git a/drivers/watchdog/pm8916_wdt.c b/drivers/watchdog/pm8916_wdt.c
> index f3fcbeb0852c..007ed139ab96 100644
> --- a/drivers/watchdog/pm8916_wdt.c
> +++ b/drivers/watchdog/pm8916_wdt.c
> @@ -218,7 +218,7 @@ static int pm8916_wdt_probe(struct platform_device *pdev)
>  		return err;
>  	}
>  
> -	wdt->wdev.ops = &pm8916_wdt_ops,
> +	wdt->wdev.ops = &pm8916_wdt_ops;
>  	wdt->wdev.parent = dev;
>  	wdt->wdev.min_timeout = PM8916_WDT_MIN_TIMEOUT;
>  	wdt->wdev.max_timeout = PM8916_WDT_MAX_TIMEOUT;
> -- 
> 2.17.1
> 

Reviewed-by: Wim Van Sebroeck <wim@...ux-watchdog.org>

And added it to linux-watchdog-next also.

Kind regards,
Wim.