linux-kernel - Re: [PATCH v2 4/4] iio: light: ltr390: Add interrupt persistance support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240914145446.21dfddec@jic23-huawei>
Date: Sat, 14 Sep 2024 14:54:46 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Abhash Jha <abhashkumarjha123@...il.com>
Cc: linux-iio@...r.kernel.org, anshulusr@...il.com, lars@...afoo.de,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] iio: light: ltr390: Add interrupt persistance
 support

On Tue, 10 Sep 2024 10:20:29 +0530
Abhash Jha <abhashkumarjha123@...il.com> wrote:

> Added support to configure the threshold interrupt persistance value by
> providing IIO_EV_INFO_PERIOD attribute. The value written to the
> attribute should be in miliseconds and should be greater than the
> sampling rate of the sensor.
> 
> Signed-off-by: Abhash Jha <abhashkumarjha123@...il.com>
> ---
>  drivers/iio/light/ltr390.c | 66 +++++++++++++++++++++++++++++++++++---
>  1 file changed, 62 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/light/ltr390.c b/drivers/iio/light/ltr390.c
> index 8a8a118ca..9706105c6 100644
> --- a/drivers/iio/light/ltr390.c
> +++ b/drivers/iio/light/ltr390.c
> @@ -40,6 +40,7 @@

>  
> -static int ltr390_get_samp_freq(struct ltr390_data *data)
> +static int ltr390_get_samp_freq_or_period(struct ltr390_data *data, enum ltr390_meas_rate option)

Wrap this as the line is getting too long.

Otherwise LGTM

Thanks,

Jonathan