linux-kernel - Re: [PATCH v2 1/4] iio: light: ltr390: Added configurable sampling frequency support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG=0RqL7y-Dmi6nAibkGOr32ufmMHS=pGjgp_7Er_oBTMqEszQ@mail.gmail.com>
Date: Sat, 14 Sep 2024 22:57:24 +0530
From: Abhash jha <abhashkumarjha123@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: linux-iio@...r.kernel.org, anshulusr@...il.com, lars@...afoo.de, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] iio: light: ltr390: Added configurable sampling
 frequency support

> Hi Abhash,
>
> A few minor comments inline and an (optional) request to cleanup
> the mask definitions in the existing code.
> >
> >  #define LTR390_PART_NUMBER_ID                0xb
> >  #define LTR390_ALS_UVS_GAIN_MASK     0x07
> > +#define LTR390_ALS_UVS_MEAS_RATE_MASK        0x07
> These masks should be converted to GENMASK().
> If you don't mind doing it a precursor patch to do so
> would be nice to have.
>
Can I do the mask to GENMASK conversion in an additional cleanup patch
at the end? The patch would clean up stuff related to newlines and such.

Meanwhile I would use GENMASK for the new ones

Thanks,
Abhash