linux-kernel - Re: [PATCH v6 0/8] iio: adc: ad7606: add support for AD7606C-{16,18} parts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240914154518.3adfbeca@jic23-huawei>
Date: Sat, 14 Sep 2024 15:45:18 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Alexandru Ardelean <aardelean@...libre.com>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, krzk+dt@...nel.org, robh@...nel.org,
 lars@...afoo.de, michael.hennerich@...log.com, gstols@...libre.com,
 dlechner@...libre.com
Subject: Re: [PATCH v6 0/8] iio: adc: ad7606: add support for
 AD7606C-{16,18} parts

On Fri, 13 Sep 2024 16:57:35 +0300
Alexandru Ardelean <aardelean@...libre.com> wrote:

> The AD7606C-16 and AD7606C-18 are pretty similar with the AD7606B.
> The main difference between AD7606C-16 & AD7606C-18 is the precision in
> bits (16 vs 18).
> Because of that, some scales need to be defined for the 18-bit variants, as
> they need to be computed against 2**18 (vs 2**16 for the 16 bit-variants).
> 
> Because the AD7606C-16,18 also supports bipolar & differential channels,
> for SW-mode, the default range of 10 V or ±10V should be set at probe.
> On reset, the default range (in the registers) is set to value 0x3 which
> corresponds to '±10 V single-ended range', regardless of bipolar or
> differential configuration.
> 
> Aside from the scale/ranges, the AD7606C-16 is similar to the AD7606B.
> 
> This changeset, does a bit of rework to the existing ad7606 driver and then
> adds support for the AD7606C-16 & AD7606C-18 parts.
Other than the issue the bot found this looks good to me.
Will let it sit on list a little while though for others to reviews,

Jonathan