linux-kernel - Re: [PATCH v6 8/8] iio: adc: ad7606: add support for AD7606C-{16,18} parts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+GgBR_OE3E7FwcAVy+hD51OPP4wcrSuEWh_9YCtH+fwTwAQLQ@mail.gmail.com>
Date: Mon, 16 Sep 2024 09:38:23 +0300
From: Alexandru Ardelean <aardelean@...libre.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: kernel test robot <lkp@...el.com>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, oe-kbuild-all@...ts.linux.dev, krzk+dt@...nel.org, 
	robh@...nel.org, lars@...afoo.de, michael.hennerich@...log.com, 
	gstols@...libre.com, dlechner@...libre.com
Subject: Re: [PATCH v6 8/8] iio: adc: ad7606: add support for AD7606C-{16,18} parts

On Sat, Sep 14, 2024 at 5:42 PM Jonathan Cameron <jic23@...nel.org> wrote:
>
> On Sat, 14 Sep 2024 04:30:42 +0800
> kernel test robot <lkp@...el.com> wrote:
>
> > Hi Alexandru,
> >
> > kernel test robot noticed the following build warnings:
> >
> > [auto build test WARNING on jic23-iio/togreg]
> > [also build test WARNING on next-20240913]
> > [cannot apply to linus/master v6.11-rc7]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> >
> > url:    https://github.com/intel-lab-lkp/linux/commits/Alexandru-Ardelean/iio-adc-ad7606-add-bits-parameter-to-channels-macros/20240913-220501
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> > patch link:    https://lore.kernel.org/r/20240913135744.152669-9-aardelean%40baylibre.com
> > patch subject: [PATCH v6 8/8] iio: adc: ad7606: add support for AD7606C-{16,18} parts
> > config: arm-randconfig-001-20240914 (https://download.01.org/0day-ci/archive/20240914/202409140416.KWHXjFSv-lkp@intel.com/config)
> > compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240914/202409140416.KWHXjFSv-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@...el.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202409140416.KWHXjFSv-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> drivers/iio/adc/ad7606.c:39:27: warning: 'ad7606_18bit_hw_scale_avail' defined but not used [-Wunused-const-variable=]
> >       39 | static const unsigned int ad7606_18bit_hw_scale_avail[2] = {
> >          |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> >
> > vim +/ad7606_18bit_hw_scale_avail +39 drivers/iio/adc/ad7606.c
> >
> >     38
> >   > 39        static const unsigned int ad7606_18bit_hw_scale_avail[2] = {
> >     40                38147, 76294
> >     41        };
> >     42
> Hmm. Seems like there is no code that would use this, so what is it
> and where did the numbers come from?

Oh that's a good catch from the CI bot.
While reworking the SW scales for AD7606C-{16,18} I dropped the HW scales.
Oddly enough, I don't get the error building locally, I may need to
add more flags to the build.
Will re-spin.

>
> Jonathan
>
> >
>