linux-kernel - Re: [PATCH 4/7] iio: light: veml6030: make use of regmap_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240914155454.0d82f4ae@jic23-huawei>
Date: Sat, 14 Sep 2024 15:54:54 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Rishi Gupta <gupt21@...il.com>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH 4/7] iio: light: veml6030: make use of regmap_set_bits()

On Fri, 13 Sep 2024 15:18:59 +0200
Javier Carrasco <javier.carrasco.cruz@...il.com> wrote:

> Instead of using regmap_update_bits() and passing val = 1, use
> regmap_set_bits().
> 
Applied but description tweaked as key here is that VEML6030_ALS_SD is 1.
If it contained other bits then this change would be wrong.


> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> ---
>  drivers/iio/light/veml6030.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c
> index df2ba3078b91..5d4c2e35b987 100644
> --- a/drivers/iio/light/veml6030.c
> +++ b/drivers/iio/light/veml6030.c
> @@ -149,8 +149,8 @@ static int veml6030_als_pwr_on(struct veml6030_data *data)
>  
>  static int veml6030_als_shut_down(struct veml6030_data *data)
>  {
> -	return regmap_update_bits(data->regmap, VEML6030_REG_ALS_CONF,
> -				 VEML6030_ALS_SD, 1);
> +	return regmap_set_bits(data->regmap, VEML6030_REG_ALS_CONF,
> +				 VEML6030_ALS_SD);
>  }
>  
>  static void veml6030_als_shut_down_action(void *data)
>