linux-kernel - [PATCH] bcachefs: Fix NULL pointer dereference in bch2_opt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240916210310.14014-1-pvmohammedanees2003@gmail.com>
Date: Mon, 16 Sep 2024 21:03:10 +0000
From: Mohammed Anees <pvmohammedanees2003@...il.com>
To: Kent Overstreet <kent.overstreet@...ux.dev>
Cc: linux-bcachefs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Mohammed Anees <pvmohammedanees2003@...il.com>,
	syzbot+37186860aa7812b331d5@...kaller.appspotmail.com
Subject: [PATCH] bcachefs: Fix NULL pointer dereference in bch2_opt_to_text

syzbot has found an general protection fault in prt_str [1].

In the prt_str function, a NULL pointer dereference occurs when the
parameter str is NULL, which is called in bch2_opt_to_text when
opt->type is BCH_OPT_STR. If an invalid index v or incorrect
flag is passed to ptr_str, then this could lead to this issue.

[1] https://syzkaller.appspot.com/bug?extid=37186860aa7812b331d5

Reported-and-tested-by: syzbot+37186860aa7812b331d5@...kaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=37186860aa7812b331d5
Signed-off-by: Mohammed Anees <pvmohammedanees2003@...il.com>
---
 fs/bcachefs/opts.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/fs/bcachefs/opts.c b/fs/bcachefs/opts.c
index e10fc1da7..72b87251c 100644
--- a/fs/bcachefs/opts.c
+++ b/fs/bcachefs/opts.c
@@ -420,8 +420,12 @@ void bch2_opt_to_text(struct printbuf *out,
 	case BCH_OPT_STR:
 		if (flags & OPT_SHOW_FULL_LIST)
 			prt_string_option(out, opt->choices, v);
-		else
-			prt_str(out, opt->choices[v]);
+		else {
+			if (opt->choices[v] == NULL)
+				pr_err("Invalid flags or index v passed to the function\n");
+			else
+				prt_str(out, opt->choices[v]);
+		}
 		break;
 	case BCH_OPT_FN:
 		opt->fn.to_text(out, c, sb, v);
-- 
2.46.0