linux-kernel - Re: [PATCH v1 1/1] tee: amdtee: Use %pUl printk() format specifier to print GUIDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c95cbc6-48b6-9cf4-8682-fc6469cb9c81@amd.com>
Date: Mon, 16 Sep 2024 13:38:27 +0530
From: Rijo Thomas <Rijo-john.Thomas@....com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Jens Wiklander <jens.wiklander@...aro.org>
Cc: Devaraj Rangasamy <Devaraj.Rangasamy@....com>,
 op-tee@...ts.trustedfirmware.org, linux-kernel@...r.kernel.org,
 Sumit Garg <sumit.garg@...aro.org>
Subject: Re: [PATCH v1 1/1] tee: amdtee: Use %pUl printk() format specifier to
 print GUIDs

On 9/13/2024 2:59 PM, Andy Shevchenko wrote:
> On Thu, Sep 12, 2024 at 07:50:08AM +0200, Jens Wiklander wrote:
>> On Wed, Sep 11, 2024 at 10:41 PM Andy Shevchenko
>> <andriy.shevchenko@...ux.intel.com> wrote:
>>>
>>> Replace the custom approach with the %pUl printk() format specifier.
>>> No functional change intended.
> 
>> Thanks, the patch looks like a nice simplificatrion.
> 
> Thank you for the review.
> 
>> Rijo, Devaraj, does this work for you?
> 
> Yes, please test, because seems others use uuid_t (UUID BE) for TEE,
> but in this driver IIUC it's guid_t (UUID LE).
> 

No, this does not work for us. I tested this patch, it does not work as expected.

%pUl gives output in uuid format (%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x).
But, what we need, is a name with the format %08x-%04x-%04x-%02x%02x%02x%02x%02x%02x%02x%02x.

Endian-ness is not an issue here. uuid generates name with 4 hypens (-).
While, in our TA naming we are using 3 hyphens (-).

Thanks,
Rijo