linux-kernel - Re: arm64: stacktrace: WARN_ON(state->common.pc == orig_pc) in kunwind_recover_return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240916141856.GA10560@redhat.com>
Date: Mon, 16 Sep 2024 16:18:56 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: Puranjay Mohan <puranjay@...nel.org>
Cc: Steven Rostedt <rostedt@...dmis.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>, Mark Rutland <mark.rutland@....com>,
	Mark Brown <broonie@...nel.org>,
	Kalesh Singh <kaleshsingh@...gle.com>,
	chenqiwu <qiwuchen55@...il.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: arm64: stacktrace: WARN_ON(state->common.pc == orig_pc) in
 kunwind_recover_return_address()

On 09/16, Puranjay Mohan wrote:
>
> Oleg Nesterov <oleg@...hat.com> writes:
>
> > given that kunwind_recover_return_address() passes idx == NULL to
> > ftrace_graph_ret_addr(), it should always return ret == state->common.pc ?
> >
> >
> > Perhaps this connects to 29c1c24a27 ("function_graph: Fix up ftrace_graph_ret_addr()")
> > and I have no idea if something like the patch below makes any sense.
> >
>
> Your finding is accurate.
>
> It has been fixed in upstream by c060f93253ca ("arm64: stacktrace: fix
> the usage of ftrace_graph_ret_addr()")

Yes, I have already found that commit, see my next email ;)

Nevertheless, thanks a lot Puranjay for the confirmation!

Oleg.