linux-kernel - Re: [PATCH v3 18/20] arm64: dts: apple: Add A10X devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7f2c1fd-bd50-4d04-a2da-67bda6f7d55c@gmail.com>
Date: Mon, 16 Sep 2024 22:52:15 +0800
From: Nick Chan <towinchenmi@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Hector Martin <marcan@...can.st>, Sven Peter <sven@...npeter.dev>,
 Alyssa Rosenzweig <alyssa@...enzweig.io>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, "Rafael J . Wysocki" <rafael@...nel.org>,
 Viresh Kumar <viresh.kumar@...aro.org>,
 Linus Walleij <linus.walleij@...aro.org>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>, Guenter Roeck
 <linux@...ck-us.net>, Catalin Marinas <catalin.marinas@....com>,
 Will Deacon <will@...nel.org>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Mark Kettenis <kettenis@...nbsd.org>, asahi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-gpio@...r.kernel.org, linux-watchdog@...r.kernel.org,
 Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>,
 Konrad Dybcio <konradybcio@...nel.org>
Subject: Re: [PATCH v3 18/20] arm64: dts: apple: Add A10X devices

On 16/9/2024 22:39, Krzysztof Kozlowski wrote:
> On Sun, Sep 15, 2024 at 03:59:03PM +0800, Nick Chan wrote:
>> From: Konrad Dybcio <konradybcio@...nel.org>
>>
>> Add DTS files for the A10X SoC and the following devices based on it:
>>
>> - Apple TV 4K
>> - iPad Pro (2nd Generation) (10.5 Inch)
>> - iPad Pro (2nd Generation) (12.9 Inch)
>>
>> Signed-off-by: Konrad Dybcio <konradybcio@...nel.org>
>> [Nick: SMP, m1n1 and Apple TV 4K support, uart interrupt and pinctrl fixes]
>> Co-developed-by: Nick Chan <towinchenmi@...il.com>
>> Signed-off-by: Nick Chan <towinchenmi@...il.com>
>> ---
>>  .../devicetree/bindings/arm/apple.yaml        |   8 +-
> 
> You need to split bindings.
Good catch. The bindings part needs to be squashed into the commit
adding the
bindings. This is a miscommited style fix up to not mention "Apple" when
we are
already in Apple ARM Machine bindings, unless it is part of the offical name
(like Apple TV).

> 
> Best regards,
> Krzysztof
> 

Nick Chan